[logback-dev] [JIRA] Updated: (LBCORE-58) AppenderBase doAppend is synchronized causing significant performance problems when calling appenders.

Ralph Goers (JIRA) noreply-jira at qos.ch
Tue Oct 14 00:42:21 CEST 2008


     [ http://jira.qos.ch/browse/LBCORE-58?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ralph Goers updated LBCORE-58:
------------------------------

    Attachment: appenderlock.txt

The attached patch moves synchronization to the appenders. This patch is rather simple. It doesn't try to fix the synchronization problems in the layouts and appenders. These will be attacked individually through separate patches.

> AppenderBase doAppend is synchronized causing significant performance problems when calling appenders.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: LBCORE-58
>                 URL: http://jira.qos.ch/browse/LBCORE-58
>             Project: logback-core
>          Issue Type: Bug
>          Components: Appender
>    Affects Versions: 0.9.10
>         Environment: All
>            Reporter: Ralph Goers
>            Assignee: Logback dev list
>         Attachments: appenderlock.txt
>
>
> Slow appenders cause Logback to be a significant bottleneck in the system.  AppenderBase doAppend is synchronized to allow Appenders to be threadsafe. This is an extremely poor way to accomplish that. Many Appenders are slow since they are dealing with I/O of some kind but may be thread safe. Where they are not they should deal with the issue at the smallest granularity possible. AppenderBase must be changed to not be synchronized and any Appenders that are not thread safe should be modified appropriately.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        


More information about the logback-dev mailing list