[logback-dev] svn commit: r1896 - logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/pattern

[noreply.ceki at qos.ch]

Author: ceki
Date: Tue Oct 28 17:54:42 2008
New Revision: 1896

Modified:
   logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/pattern/DateConverter.java

Log:
Add comment in relation to LBCLASSIC-36

Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/pattern/DateConverter.java
==============================================================================
--- logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/pattern/DateConverter.java	(original)
+++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/pattern/DateConverter.java	Tue Oct 28 17:54:42 2008
@@ -62,6 +62,9 @@
       return timesmapStr;
     } else {
       lastTimestamp = timestamp;
+      // SimpleDateFormat is not thread safe. However, since
+      // the AppenderBase.doAppend is synchronized, we are should be
+      // OK. See also http://jira.qos.ch/browse/LBCLASSIC-36
       timesmapStr = simpleFormat.format(new Date(timestamp));
       return timesmapStr;
     }