[logback-dev] [JIRA] Commented: (LBCLASSIC-22) feature request: XMLLayout (cfr. log4j)
Ceki Gulcu (JIRA)
noreply-jira at qos.ch
Fri Feb 6 17:18:47 CET 2009
[ http://jira.qos.ch/browse/LBCLASSIC-22?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11036#action_11036 ]
Ceki Gulcu commented on LBCLASSIC-22:
The meaning of "as found in our repository" was "as *currently* found
in our repository". I was not intimating any precedence with respect
to your contribution.
> My character transformation is a clean design working well without the
> disambiguity of the CDATA (is a <tag> a real tag or a part of a CDATA
> stream) and as an added benefit generates 7-bit clean output.
There is no need to generate 7-bit clean ouput, as we are generating
an XML document which supports UTF-8 encoding by default.
In your version, the block relating to locationInfo creates various new caller
converters, which are quite unnecessary.
> I have produced a neat implementation conforming to logback
> conventions and tested it with Chainsaw. You haven't even made a
> single comment on this issue even though its been in here for 14
> months, decided to disregard my work and just grab the log4j
> implementation, add the MDC lines and calling it FIXED.
While I have not made any comments per se, I have assigned the issue
to me in the recent weeks, signaling that I intended to work on the
Your work has not been discarded. Although it has not been adopted as
is, your contribution has given the necessary impetus to get this
issue fixed. I have looked at your code and adopted parts of it. Hence
the author attribution to you. Not all code contributions get
accepted as is.
I welcome any any specific comments you might have on the code which
is currently in SVN, including comparisons with your contribution.
> I would have appreciated discussing this on logback-dev before the
> fact and not in comments after the fact.
The code in SVN is a basis for discussion. Again, I welcome any
comments you might have on this topic.
> As it is now I see no reason my name is in the @authors tag in the
> file, and I would appreciate it if you removed it.
I have already explained why the @author tag was justified. If you
still wish to see your name removed, please let me know.
> feature request: XMLLayout (cfr. log4j)
> Key: LBCLASSIC-22
> URL: http://jira.qos.ch/browse/LBCLASSIC-22
> Project: logback-classic
> Issue Type: Improvement
> Components: Other
> Affects Versions: unspecified
> Environment: Operating System: Linux
> Platform: PC
> Reporter: dirk
> Assignee: Ceki Gulcu
> Priority: Minor
> Fix For: 0.9.15
> Attachments: XMLLayout.jar, XMLLayout.java
> see Summary
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
More information about the logback-dev