[logback-dev] [JIRA] Commented: (LBCLASSIC-36) Synchronization of SimpleDateFormat object in DateConverter

[Ceki Gulcu (JIRA)]

    [ http://jira.qos.ch/browse/LBCLASSIC-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11198#action_11198 ] 

Ceki Gulcu commented on LBCLASSIC-36:
-------------------------------------

With your patch applied:
=== DateFormatting ===
java.runtime.version = 1.6.0_05-b13
java.vendor          = Sun Microsystems Inc.
java.version         = 1.6.0_05
os.name              = Windows XP
os.version           = 5.1
JODA: total of 21601629 operations, or 7200 operations per millisecond
SDF:  total of 28017761 operations, or 9339 operations per millisecond

Approx. 5 fold improvement. Very nice.

I am running the test from within Eclipse.  Why do you think IDEA or Eclipse influences the outcome? Do you have anything specific in mind?



> Synchronization of SimpleDateFormat object in DateConverter
> -----------------------------------------------------------
>
>                 Key: LBCLASSIC-36
>                 URL: http://jira.qos.ch/browse/LBCLASSIC-36
>             Project: logback-classic
>          Issue Type: Bug
>          Components: Other
>    Affects Versions: unspecified
>         Environment: Operating System: All
> Platform: All
>            Reporter: Anders Hammar
>            Assignee: Ceki Gulcu
>         Attachments: DateConverter_patch.java, DateFormatPerfTest.java, dateformattest.zip, DoubleCheckedLocking.patch
>
>
> According to the API documentation of SimpleDateFormat, date formats are not synchronized and it is recommended to create separate format instances for each thread.
> However, a possibly simpler (mer efficient) solution would be to synchronize on the SimpleDateFormat object in the convert() method to prevent two threads to access it concurrently.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira