[logback-dev] RFC 5424 and Structured Data support.
rgoers at apache.org
Thu Jan 7 02:41:25 CET 2010
On Dec 24, 2009, at 3:59 PM, Ralph Goers wrote:
> On Dec 13, 2009, at 4:45 PM, Ralph Goers wrote:
>> On Dec 13, 2009, at 2:14 PM, Ceki Gülcü wrote:
>>> Ralph Goers wrote:
>>>> The only issue I found was with LoggingEventSerializationPerfTest. It failed because averageSize exceeds averageSizeLimit. I've looked at that code but for the life of me I can't understand what it is attempting to validate. The size seems to be calculated by incrementing a counter everyting NoopOutputStream's write method is called. My guess is that this is an attempt to determine the length of the serialized data. The trouble is, when I changed the output stream to a FileOutputStream and serialized the object to it then size of the file was not even close to the value returned by NoopOutputStream's size method. Is that what is being attempted here? What is the real value in limiting the size? When I looked at the test the limit on the first test is 60 while the actual is 58. With the Message object replacing the message string and parameters the value is now 68.
>>> LoggingEventSerializationPerfTest serves as a regression test. The
>>> idea was to catch unsolicited increases (regressions) in the size of
>>> the serialized messages. There is nothing sacred about the number 60.
>> Ok. If you'd care to take a look it is available at git://github.com/rgoers/slf4j.git and git://github.com/rgoers/logback.git.
> Merry Christmas!
> I've made some minor changes to this. I'd appreciate a review of this and comments if you can find the time.
I hope you had a happy new year. I'm still hoping you can find time to review this.
More information about the logback-dev