[logback-dev] [JIRA] Commented: (LBCORE-194) DBAppenderBase uses EVENT_ID column name, but does not use DBNameResolver.

[Roy Cronise (JIRA)]

    [ http://jira.qos.ch/browse/LBCORE-194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11947#action_11947 ] 

Roy Cronise commented on LBCORE-194:
------------------------------------

Suggested fix:

DBAppenderBase.java:
1 - Add abstract method getEventIdColName();
2- Replace hardcoded EVENT_ID column name with getEventIdColName();


DBAppender.java:

1) In start() method add "eventIdColName = dbNameResolver.getColumnName(ColumnName.EVENT_ID);"
2) Add method:
  @Override
  protected String getEventIdColName() {
    return eventIdColName;
  }

> DBAppenderBase uses EVENT_ID column name, but does not use DBNameResolver.
> --------------------------------------------------------------------------
>
>                 Key: LBCORE-194
>                 URL: http://jira.qos.ch/browse/LBCORE-194
>             Project: logback-core
>          Issue Type: Bug
>          Components: Appender
>    Affects Versions: 0.9.28
>            Reporter: Roy Cronise
>            Assignee: Logback dev list
>
> DBAppenderBase uses EVENT_ID column name when creating the prepared statement:
> String EVENT_ID_COL_NAME = "EVENT_ID";      
>  insertStatement = connection.prepareStatement(getInsertSQL(),
>             new String[] { EVENT_ID_COL_NAME });
> Column name should be resolved using the DBNameResolver.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira