[logback-dev] [qos-ch/logback] 182150: moved MockContext to .mock package and changed to ...

Carl Harris ceharris at vt.edu
Tue Apr 2 20:16:55 CEST 2013


  Branch: refs/heads/master
  Home:   https://github.com/qos-ch/logback
  Commit: 182150017b5c8561c74b27de2085dea4129ffd6a
      https://github.com/qos-ch/logback/commit/182150017b5c8561c74b27de2085dea4129ffd6a
  Author: Carl Harris <ceharris at vt.edu>
  Date:   2013-04-02 (Tue, 02 Apr 2013)

  Changed paths:
    R logback-core/src/test/java/ch/qos/logback/core/net/MockContext.java
    M logback-core/src/test/java/ch/qos/logback/core/net/SSLSocketAppenderBaseTest.java
    A logback-core/src/test/java/ch/qos/logback/core/net/mock/MockContext.java

  Log Message:
  -----------
  moved MockContext to .mock package and changed to public


  Commit: cbea8330b0a75027442c9b4edd684c2690053b4d
      https://github.com/qos-ch/logback/commit/cbea8330b0a75027442c9b4edd684c2690053b4d
  Author: Carl Harris <ceharris at vt.edu>
  Date:   2013-04-02 (Tue, 02 Apr 2013)

  Changed paths:
    A logback-core/src/main/java/ch/qos/logback/core/net/server/ServerSocketAppenderBase.java

  Log Message:
  -----------
  added initial definition of ServerSocketAppenderBase


  Commit: 39481b77adf5f371da95acb294cc86ce0e89a7cd
      https://github.com/qos-ch/logback/commit/39481b77adf5f371da95acb294cc86ce0e89a7cd
  Author: Carl Harris <ceharris at vt.edu>
  Date:   2013-04-02 (Tue, 02 Apr 2013)

  Changed paths:
    A logback-core/src/main/java/ch/qos/logback/core/net/server/SSLServerSocketAppenderBase.java
    A logback-core/src/test/java/ch/qos/logback/core/net/server/SSLServerSocketAppenderBaseTest.java

  Log Message:
  -----------
  added SSLServerSocketAppenderBase and associated test class


  Commit: 9ab2a7e63781e73f348f49834c511061c254d421
      https://github.com/qos-ch/logback/commit/9ab2a7e63781e73f348f49834c511061c254d421
  Author: Carl Harris <ceharris at vt.edu>
  Date:   2013-04-02 (Tue, 02 Apr 2013)

  Changed paths:
    A logback-core/src/main/java/ch/qos/logback/core/net/server/package.html

  Log Message:
  -----------
  added package javadoc for ..core.net.server


  Commit: aa25253552ad4766108289f5783d9f4436f20f3f
      https://github.com/qos-ch/logback/commit/aa25253552ad4766108289f5783d9f4436f20f3f
  Author: Carl Harris <ceharris at vt.edu>
  Date:   2013-04-02 (Tue, 02 Apr 2013)

  Changed paths:
    M logback-classic/src/main/java/ch/qos/logback/classic/net/server/Client.java
    M logback-classic/src/main/java/ch/qos/logback/classic/net/server/ConcurrentServerRunner.java
    A logback-classic/src/main/java/ch/qos/logback/classic/net/server/RemoteAppenderClient.java
    A logback-classic/src/main/java/ch/qos/logback/classic/net/server/RemoteAppenderServerListener.java
    A logback-classic/src/main/java/ch/qos/logback/classic/net/server/RemoteAppenderServerRunner.java
    A logback-classic/src/main/java/ch/qos/logback/classic/net/server/RemoteAppenderStreamClient.java
    M logback-classic/src/main/java/ch/qos/logback/classic/net/server/ServerListener.java
    M logback-classic/src/main/java/ch/qos/logback/classic/net/server/ServerSocketListener.java
    M logback-classic/src/main/java/ch/qos/logback/classic/net/server/SocketServer.java
    R logback-classic/src/main/java/ch/qos/logback/classic/net/server/StreamClient.java
    M logback-classic/src/test/java/ch/qos/logback/classic/net/server/ConcurrentServerRunnerTest.java
    M logback-classic/src/test/java/ch/qos/logback/classic/net/server/InstrumentedSocketServer.java
    M logback-classic/src/test/java/ch/qos/logback/classic/net/server/MockClient.java
    M logback-classic/src/test/java/ch/qos/logback/classic/net/server/MockServerListener.java
    M logback-classic/src/test/java/ch/qos/logback/classic/net/server/ServerSocketListenerTest.java
    M logback-classic/src/test/java/ch/qos/logback/classic/net/server/SocketServerTest.java
    M logback-classic/src/test/java/ch/qos/logback/classic/net/server/StreamClientTest.java

  Log Message:
  -----------
  converted server support classes to use generics

The ServerListener was converted to use a type parameter for the Client
subtype.  The Client interface was stripped down and the
remote-appender-specific methods were moved to a subinterface.  These
changes allowed the ConcurrentServerRunner and ServerSocketListener to
use a generic Client and to be reworked to move all of the
remote-appender-specific code to subclasses.  With these changes the
abstract base classes and interfaces can be moved to core to support
other server types.


  Commit: 23c74f411ff79faa3f4bb4e0f984f6edaf8626b4
      https://github.com/qos-ch/logback/commit/23c74f411ff79faa3f4bb4e0f984f6edaf8626b4
  Author: Carl Harris <ceharris at vt.edu>
  Date:   2013-04-02 (Tue, 02 Apr 2013)

  Changed paths:
    M logback-classic/src/main/java/ch/qos/logback/classic/net/server/Client.java
    M logback-classic/src/main/java/ch/qos/logback/classic/net/server/ConcurrentServerRunner.java
    M logback-classic/src/main/java/ch/qos/logback/classic/net/server/ServerListener.java
    M logback-classic/src/main/java/ch/qos/logback/classic/net/server/ServerRunner.java
    M logback-classic/src/main/java/ch/qos/logback/classic/net/server/ServerSocketListener.java

  Log Message:
  -----------
  added public modifier to abstract server classes


  Commit: 1e7ed7679a014e424f7da5a5996fc09383b8294d
      https://github.com/qos-ch/logback/commit/1e7ed7679a014e424f7da5a5996fc09383b8294d
  Author: Carl Harris <ceharris at vt.edu>
  Date:   2013-04-02 (Tue, 02 Apr 2013)

  Changed paths:
    M logback-classic/src/main/java/ch/qos/logback/classic/net/server/ServerRunner.java

  Log Message:
  -----------
  removed references to SocketRunner

The javadoc references to SocketRunner will cause an unwanted important
when this interface is moved to core.


  Commit: 09ea873b408e07a19f012dd82fe8433ac47c99c3
      https://github.com/qos-ch/logback/commit/09ea873b408e07a19f012dd82fe8433ac47c99c3
  Author: Carl Harris <ceharris at vt.edu>
  Date:   2013-04-02 (Tue, 02 Apr 2013)

  Changed paths:
    M logback-classic/src/main/java/ch/qos/logback/classic/net/server/ConcurrentServerRunner.java
    M logback-classic/src/main/java/ch/qos/logback/classic/net/server/RemoteAppenderServerRunner.java

  Log Message:
  -----------
  moved references to slf4j and classic into subclass

When the ConcurrentServerRunner is moved to core, it cannot reference
directly the Logger and LoggerContext objects.  Now the base class
delegates its logging to a subclass.


  Commit: 98b665e5423de77794416309353edab994e0017f
      https://github.com/qos-ch/logback/commit/98b665e5423de77794416309353edab994e0017f
  Author: Carl Harris <ceharris at vt.edu>
  Date:   2013-04-02 (Tue, 02 Apr 2013)

  Changed paths:
    M logback-classic/src/test/java/ch/qos/logback/classic/net/server/ConcurrentServerRunnerTest.java

  Log Message:
  -----------
  provide no-op logging methods in InstrumentedConcurrentServerRunner


  Commit: 9fdfb7c27616106e7f6535cca0cb58a2f7a73d2e
      https://github.com/qos-ch/logback/commit/9fdfb7c27616106e7f6535cca0cb58a2f7a73d2e
  Author: Carl Harris <ceharris at vt.edu>
  Date:   2013-04-02 (Tue, 02 Apr 2013)

  Changed paths:
    A logback-classic/src/test/java/ch/qos/logback/classic/net/server/RemoteAppenderStreamClientTest.java
    R logback-classic/src/test/java/ch/qos/logback/classic/net/server/StreamClientTest.java

  Log Message:
  -----------
  renamed StreamClientTest to RemoteAppenderStreamClient test


  Commit: a5faeaac8618c52a21688a1e90957837d16cf86a
      https://github.com/qos-ch/logback/commit/a5faeaac8618c52a21688a1e90957837d16cf86a
  Author: Carl Harris <ceharris at vt.edu>
  Date:   2013-04-02 (Tue, 02 Apr 2013)

  Changed paths:
    R logback-classic/src/main/java/ch/qos/logback/classic/net/server/Client.java
    R logback-classic/src/main/java/ch/qos/logback/classic/net/server/ConcurrentServerRunner.java
    M logback-classic/src/main/java/ch/qos/logback/classic/net/server/RemoteAppenderClient.java
    M logback-classic/src/main/java/ch/qos/logback/classic/net/server/RemoteAppenderServerListener.java
    M logback-classic/src/main/java/ch/qos/logback/classic/net/server/RemoteAppenderServerRunner.java
    R logback-classic/src/main/java/ch/qos/logback/classic/net/server/ServerListener.java
    R logback-classic/src/main/java/ch/qos/logback/classic/net/server/ServerRunner.java
    R logback-classic/src/main/java/ch/qos/logback/classic/net/server/ServerSocketListener.java
    M logback-classic/src/main/java/ch/qos/logback/classic/net/server/SocketServer.java
    R logback-classic/src/test/java/ch/qos/logback/classic/net/server/ConcurrentServerRunnerTest.java
    M logback-classic/src/test/java/ch/qos/logback/classic/net/server/InstrumentedSocketServer.java
    R logback-classic/src/test/java/ch/qos/logback/classic/net/server/MockClient.java
    R logback-classic/src/test/java/ch/qos/logback/classic/net/server/MockContext.java
    R logback-classic/src/test/java/ch/qos/logback/classic/net/server/MockServerListener.java
    R logback-classic/src/test/java/ch/qos/logback/classic/net/server/MockServerRunner.java
    M logback-classic/src/test/java/ch/qos/logback/classic/net/server/SSLSocketServerTest.java
    R logback-classic/src/test/java/ch/qos/logback/classic/net/server/ServerSocketListenerTest.java
    R logback-classic/src/test/java/ch/qos/logback/classic/net/server/ServerSocketUtil.java
    M logback-classic/src/test/java/ch/qos/logback/classic/net/server/SocketServerFunctionalTest.java
    M logback-classic/src/test/java/ch/qos/logback/classic/net/server/SocketServerTest.java
    A logback-core/src/main/java/ch/qos/logback/core/net/server/Client.java
    A logback-core/src/main/java/ch/qos/logback/core/net/server/ConcurrentServerRunner.java
    A logback-core/src/main/java/ch/qos/logback/core/net/server/ServerListener.java
    A logback-core/src/main/java/ch/qos/logback/core/net/server/ServerRunner.java
    A logback-core/src/main/java/ch/qos/logback/core/net/server/ServerSocketListener.java
    A logback-core/src/test/java/ch/qos/logback/core/net/server/ConcurrentServerRunnerTest.java
    A logback-core/src/test/java/ch/qos/logback/core/net/server/MockClient.java
    A logback-core/src/test/java/ch/qos/logback/core/net/server/MockContext.java
    A logback-core/src/test/java/ch/qos/logback/core/net/server/MockServerListener.java
    A logback-core/src/test/java/ch/qos/logback/core/net/server/MockServerRunner.java
    A logback-core/src/test/java/ch/qos/logback/core/net/server/ServerSocketListenerTest.java
    A logback-core/src/test/java/ch/qos/logback/core/net/server/ServerSocketUtil.java

  Log Message:
  -----------
  moved supporting abstractions for server from classic to core


  Commit: 5153e899d3cb0b5c11683163bdf6ede2f8780a89
      https://github.com/qos-ch/logback/commit/5153e899d3cb0b5c11683163bdf6ede2f8780a89
  Author: Carl Harris <ceharris at vt.edu>
  Date:   2013-04-02 (Tue, 02 Apr 2013)

  Changed paths:
    M logback-classic/src/main/java/ch/qos/logback/classic/net/server/SocketServer.java
    M logback-classic/src/main/java/ch/qos/logback/classic/net/server/SocketServerNestedComponentRegistryRules.java
    R logback-classic/src/main/java/ch/qos/logback/classic/net/server/ThreadPoolFactoryBean.java
    M logback-classic/src/test/java/ch/qos/logback/classic/net/server/MockThreadPoolFactoryBean.java
    M logback-classic/src/test/java/ch/qos/logback/classic/net/server/SocketServerFunctionalTest.java
    A logback-core/src/main/java/ch/qos/logback/core/net/server/ThreadPoolFactoryBean.java

  Log Message:
  -----------
  moved ThreadPoolFactoryBean to ..core.net.server


  Commit: 7752061e0ccd68d7a99390e5b995b8934d71552d
      https://github.com/qos-ch/logback/commit/7752061e0ccd68d7a99390e5b995b8934d71552d
  Author: Carl Harris <ceharris at vt.edu>
  Date:   2013-04-02 (Tue, 02 Apr 2013)

  Changed paths:
    M logback-core/src/main/java/ch/qos/logback/core/net/server/ConcurrentServerRunner.java
    M logback-core/src/main/java/ch/qos/logback/core/net/server/ServerRunner.java
    M logback-core/src/test/java/ch/qos/logback/core/net/server/ConcurrentServerRunnerTest.java
    M logback-core/src/test/java/ch/qos/logback/core/net/server/MockServerRunner.java

  Log Message:
  -----------
  added ServerRunner.accept(ClientVisitor)

This method will allow a user of a ServerRunner to visit each of the
connected clients in order to do something with the client.


  Commit: f5c38f2592256ed086df82b466be7a9a6c9d3521
      https://github.com/qos-ch/logback/commit/f5c38f2592256ed086df82b466be7a9a6c9d3521
  Author: Carl Harris <ceharris at vt.edu>
  Date:   2013-04-02 (Tue, 02 Apr 2013)

  Changed paths:
    A logback-core/src/main/java/ch/qos/logback/core/net/server/ClientVisitor.java
    A logback-core/src/test/java/ch/qos/logback/core/net/server/MockClientVisitor.java

  Log Message:
  -----------
  added missing ClientVisitor interface and mock


  Commit: 7964d6e9246f3c4323724f3d0a21ea42582f5d3c
      https://github.com/qos-ch/logback/commit/7964d6e9246f3c4323724f3d0a21ea42582f5d3c
  Author: Carl Harris <ceharris at vt.edu>
  Date:   2013-04-02 (Tue, 02 Apr 2013)

  Changed paths:
    A logback-core/src/main/java/ch/qos/logback/core/net/server/RemoteLoggerClient.java
    A logback-core/src/main/java/ch/qos/logback/core/net/server/RemoteLoggerServerListener.java
    A logback-core/src/main/java/ch/qos/logback/core/net/server/RemoteLoggerServerRunner.java
    A logback-core/src/main/java/ch/qos/logback/core/net/server/RemoteLoggerStreamClient.java

  Log Message:
  -----------
  added supporting classes for serving logging events to remote loggers


  Commit: 9476bc6345e54f60c912a9be5cbf74537d3a80b9
      https://github.com/qos-ch/logback/commit/9476bc6345e54f60c912a9be5cbf74537d3a80b9
  Author: Carl Harris <ceharris at vt.edu>
  Date:   2013-04-02 (Tue, 02 Apr 2013)

  Changed paths:
    M logback-core/src/main/java/ch/qos/logback/core/net/server/ConcurrentServerRunner.java

  Log Message:
  -----------
  delegated ConcurrentServerRunner.stop() to .accept(ClientVisitor)

The stop method was iterating a copy of the collection.  Since this is
exactly what accept(ClientVisitor) does, stop can simply delegate to
accept with a visitor that closes each visited client.


  Commit: 9f90fb4800d34c2d73b219b1efd3a46bb2efd1d1
      https://github.com/qos-ch/logback/commit/9f90fb4800d34c2d73b219b1efd3a46bb2efd1d1
  Author: Carl Harris <ceharris at vt.edu>
  Date:   2013-04-02 (Tue, 02 Apr 2013)

  Changed paths:
    M logback-core/src/main/java/ch/qos/logback/core/net/server/RemoteLoggerClient.java
    M logback-core/src/main/java/ch/qos/logback/core/net/server/RemoteLoggerStreamClient.java

  Log Message:
  -----------
  RemoteLoggerClient now allows the event queue to be configured

Previously only the queue size was exposed.  Having the queue itself
exposed for configuration makes it easier to write a unit test that
isn't overly complicated.


  Commit: 827aba17b6f905ac1695f4cd7661f584f5ee10b4
      https://github.com/qos-ch/logback/commit/827aba17b6f905ac1695f4cd7661f584f5ee10b4
  Author: Carl Harris <ceharris at vt.edu>
  Date:   2013-04-02 (Tue, 02 Apr 2013)

  Changed paths:
    A logback-core/src/test/java/ch/qos/logback/core/net/server/MockEventQueue.java
    A logback-core/src/test/java/ch/qos/logback/core/net/server/RemoteLoggerStreamClientTest.java

  Log Message:
  -----------
  added unit test for RemoteLoggerStreamClient


  Commit: 3f8b5504082165fa8c94fcd4ba4243fc96f94882
      https://github.com/qos-ch/logback/commit/3f8b5504082165fa8c94fcd4ba4243fc96f94882
  Author: Carl Harris <ceharris at vt.edu>
  Date:   2013-04-02 (Tue, 02 Apr 2013)

  Changed paths:
    M logback-core/src/main/java/ch/qos/logback/core/net/server/RemoteLoggerServerRunner.java

  Log Message:
  -----------
  updated RemoteLoggerServerRunner to configure client's event queue


  Commit: d870375940ec040ee88ea5b38c79b9005e5b2641
      https://github.com/qos-ch/logback/commit/d870375940ec040ee88ea5b38c79b9005e5b2641
  Author: Carl Harris <ceharris at vt.edu>
  Date:   2013-04-02 (Tue, 02 Apr 2013)

  Changed paths:
    M logback-core/src/test/java/ch/qos/logback/core/net/server/MockServerRunner.java

  Log Message:
  -----------
  added type parameter to MockServerRunner


  Commit: 38a5b7a43ea58a5a1da3e1f9fcbbe37213dbd769
      https://github.com/qos-ch/logback/commit/38a5b7a43ea58a5a1da3e1f9fcbbe37213dbd769
  Author: Carl Harris <ceharris at vt.edu>
  Date:   2013-04-02 (Tue, 02 Apr 2013)

  Changed paths:
    M logback-core/src/main/java/ch/qos/logback/core/net/server/ServerSocketAppenderBase.java
    A logback-core/src/test/java/ch/qos/logback/core/net/server/InstrumentedServerSocketAppenderBase.java
    A logback-core/src/test/java/ch/qos/logback/core/net/server/MockThreadPoolFactoryBean.java
    A logback-core/src/test/java/ch/qos/logback/core/net/server/ServerSocketAppenderBaseTest.java

  Log Message:
  -----------
  Completed implementation of ServerSocketAppenderBase

Implemented lifecyle and appender methods, and added unit tests and
supporting classes.


  Commit: 45b328434e16783204481fa15a1b878c7ae858ce
      https://github.com/qos-ch/logback/commit/45b328434e16783204481fa15a1b878c7ae858ce
  Author: Carl Harris <ceharris at vt.edu>
  Date:   2013-04-02 (Tue, 02 Apr 2013)

  Changed paths:
    A logback-core/src/test/java/ch/qos/logback/core/net/server/ServerSocketAppenderBaseFunctionalTest.java

  Log Message:
  -----------
  added a functional test for ServerSocketAppenderBase


  Commit: f52a4684d6ba978c95aebbe1c1737cd69c7737cb
      https://github.com/qos-ch/logback/commit/f52a4684d6ba978c95aebbe1c1737cd69c7737cb
  Author: Carl Harris <ceharris at vt.edu>
  Date:   2013-04-02 (Tue, 02 Apr 2013)

  Changed paths:
    M logback-classic/src/test/java/ch/qos/logback/classic/net/server/InstrumentedSocketServer.java
    M logback-classic/src/test/java/ch/qos/logback/classic/net/server/SocketServerTest.java

  Log Message:
  -----------
  added type parameters for client type to test support classes


  Commit: 67dbcc9a4afe156a253c31b16c676a746bf93cb3
      https://github.com/qos-ch/logback/commit/67dbcc9a4afe156a253c31b16c676a746bf93cb3
  Author: Carl Harris <ceharris at vt.edu>
  Date:   2013-04-02 (Tue, 02 Apr 2013)

  Changed paths:
    M logback-classic/src/main/java/ch/qos/logback/classic/net/server/RemoteAppenderServerListener.java
    M logback-classic/src/main/java/ch/qos/logback/classic/net/server/RemoteAppenderStreamClient.java

  Log Message:
  -----------
  ensure that socket resources are closed by RemoteAppenderStreamClient

In the existing RemoteAppenderStreamClient, an InputStream obtained from
the underlying socket was passed in the constructor.  While the client
implementation closed the stream, it did not close the socket.  Now the
socket is passed to the client to ensure the socket gets closed.


  Commit: 1f3983b2f7fead31c623a566aa5d88ab2c68e05f
      https://github.com/qos-ch/logback/commit/1f3983b2f7fead31c623a566aa5d88ab2c68e05f
  Author: Carl Harris <ceharris at vt.edu>
  Date:   2013-04-02 (Tue, 02 Apr 2013)

  Changed paths:
    M logback-classic/src/test/java/ch/qos/logback/classic/net/server/InstrumentedSocketServer.java
    M logback-classic/src/test/java/ch/qos/logback/classic/net/server/MockThreadPoolFactoryBean.java
    M logback-classic/src/test/java/ch/qos/logback/classic/net/server/SocketServerFunctionalTest.java
    M logback-classic/src/test/java/ch/qos/logback/classic/net/server/SocketServerTest.java
    M logback-core/src/main/java/ch/qos/logback/core/net/server/ThreadPoolFactoryBean.java
    M logback-core/src/test/java/ch/qos/logback/core/net/server/InstrumentedServerSocketAppenderBase.java
    M logback-core/src/test/java/ch/qos/logback/core/net/server/MockThreadPoolFactoryBean.java
    M logback-core/src/test/java/ch/qos/logback/core/net/server/ServerSocketAppenderBaseFunctionalTest.java
    M logback-core/src/test/java/ch/qos/logback/core/net/server/ServerSocketAppenderBaseTest.java

  Log Message:
  -----------
  ThreadPoolFactoryBean.createExecutor now returns an ExecutorService

This will allow the created ExecutorService to be shutdown in the
relevant stop method.


  Commit: f880c687b2d0755eb6e0a41ffe3dec83e3fac46a
      https://github.com/qos-ch/logback/commit/f880c687b2d0755eb6e0a41ffe3dec83e3fac46a
  Author: Carl Harris <ceharris at vt.edu>
  Date:   2013-04-02 (Tue, 02 Apr 2013)

  Changed paths:
    M logback-core/src/main/java/ch/qos/logback/core/net/server/ServerSocketAppenderBase.java
    M logback-core/src/test/java/ch/qos/logback/core/net/server/ServerSocketAppenderBaseFunctionalTest.java

  Log Message:
  -----------
  ServerSocketAppenderBase.stop() now invokes executor.shutdownNow()

This ensures that any clients that are blocked waiting to take the next
event from the queue will shut down cleanly.


  Commit: 76d0bc4cba684d0c70c5cd9c0c82c40dab261177
      https://github.com/qos-ch/logback/commit/76d0bc4cba684d0c70c5cd9c0c82c40dab261177
  Author: Carl Harris <ceharris at vt.edu>
  Date:   2013-04-02 (Tue, 02 Apr 2013)

  Changed paths:
    M logback-classic/src/main/java/ch/qos/logback/classic/net/server/SocketServer.java

  Log Message:
  -----------
  SocketServer.stop() now invokes ExecutorService.shutdownNow()

This was done to be consistent with the implementation in
ServerSocketAppenderBase, but isn't strictly required, as all concurrent
tasks for this server will be blocked in I/O calls, not thread waits.


  Commit: edf75ee449cf93652ee6446af062e04594c1de92
      https://github.com/qos-ch/logback/commit/edf75ee449cf93652ee6446af062e04594c1de92
  Author: Carl Harris <ceharris at vt.edu>
  Date:   2013-04-02 (Tue, 02 Apr 2013)

  Changed paths:
    M logback-classic/src/main/java/ch/qos/logback/classic/net/server/RemoteAppenderStreamClient.java

  Log Message:
  -----------
  fixed a potential NPE in RemoteAppenderStreamClient.run

The ObjectInputStream reference (oos) was being closed without checking
to see if it was ever created.  If the ObjectInputStream constructor
happened to throw an exception, we'd have an NPE here.  Not likely, but
worth handling properly.


  Commit: 45159ceed9163e4d0c48b7ec73180631d8b53fde
      https://github.com/qos-ch/logback/commit/45159ceed9163e4d0c48b7ec73180631d8b53fde
  Author: Carl Harris <ceharris at vt.edu>
  Date:   2013-04-02 (Tue, 02 Apr 2013)

  Changed paths:
    M logback-classic/src/main/java/ch/qos/logback/classic/net/server/RemoteAppenderClient.java
    M logback-core/src/main/java/ch/qos/logback/core/net/server/RemoteLoggerClient.java
    M logback-core/src/main/java/ch/qos/logback/core/net/server/RemoteLoggerServerListener.java
    M logback-core/src/main/java/ch/qos/logback/core/net/server/RemoteLoggerServerRunner.java

  Log Message:
  -----------
  changed server implementation classes to package-private visibility

These classes are all part of the implementation and should not be
visible outside of the package.


  Commit: ce038c12261a6815286a2bb4916a10e308c832e2
      https://github.com/qos-ch/logback/commit/ce038c12261a6815286a2bb4916a10e308c832e2
  Author: Carl Harris <ceharris at vt.edu>
  Date:   2013-04-02 (Tue, 02 Apr 2013)

  Changed paths:
    R logback-classic/src/main/java/ch/qos/logback/classic/net/server/Client.java
    R logback-classic/src/main/java/ch/qos/logback/classic/net/server/ConcurrentServerRunner.java
    A logback-classic/src/main/java/ch/qos/logback/classic/net/server/RemoteAppenderClient.java
    A logback-classic/src/main/java/ch/qos/logback/classic/net/server/RemoteAppenderServerListener.java
    A logback-classic/src/main/java/ch/qos/logback/classic/net/server/RemoteAppenderServerRunner.java
    A logback-classic/src/main/java/ch/qos/logback/classic/net/server/RemoteAppenderStreamClient.java
    R logback-classic/src/main/java/ch/qos/logback/classic/net/server/ServerListener.java
    R logback-classic/src/main/java/ch/qos/logback/classic/net/server/ServerRunner.java
    R logback-classic/src/main/java/ch/qos/logback/classic/net/server/ServerSocketListener.java
    M logback-classic/src/main/java/ch/qos/logback/classic/net/server/SocketServer.java
    M logback-classic/src/main/java/ch/qos/logback/classic/net/server/SocketServerNestedComponentRegistryRules.java
    R logback-classic/src/main/java/ch/qos/logback/classic/net/server/StreamClient.java
    R logback-classic/src/main/java/ch/qos/logback/classic/net/server/ThreadPoolFactoryBean.java
    R logback-classic/src/test/java/ch/qos/logback/classic/net/server/ConcurrentServerRunnerTest.java
    M logback-classic/src/test/java/ch/qos/logback/classic/net/server/InstrumentedSocketServer.java
    R logback-classic/src/test/java/ch/qos/logback/classic/net/server/MockClient.java
    R logback-classic/src/test/java/ch/qos/logback/classic/net/server/MockContext.java
    R logback-classic/src/test/java/ch/qos/logback/classic/net/server/MockServerListener.java
    R logback-classic/src/test/java/ch/qos/logback/classic/net/server/MockServerRunner.java
    M logback-classic/src/test/java/ch/qos/logback/classic/net/server/MockThreadPoolFactoryBean.java
    A logback-classic/src/test/java/ch/qos/logback/classic/net/server/RemoteAppenderStreamClientTest.java
    M logback-classic/src/test/java/ch/qos/logback/classic/net/server/SSLSocketServerTest.java
    R logback-classic/src/test/java/ch/qos/logback/classic/net/server/ServerSocketListenerTest.java
    R logback-classic/src/test/java/ch/qos/logback/classic/net/server/ServerSocketUtil.java
    M logback-classic/src/test/java/ch/qos/logback/classic/net/server/SocketServerFunctionalTest.java
    M logback-classic/src/test/java/ch/qos/logback/classic/net/server/SocketServerTest.java
    R logback-classic/src/test/java/ch/qos/logback/classic/net/server/StreamClientTest.java
    A logback-core/src/main/java/ch/qos/logback/core/net/server/Client.java
    A logback-core/src/main/java/ch/qos/logback/core/net/server/ClientVisitor.java
    A logback-core/src/main/java/ch/qos/logback/core/net/server/ConcurrentServerRunner.java
    A logback-core/src/main/java/ch/qos/logback/core/net/server/RemoteLoggerClient.java
    A logback-core/src/main/java/ch/qos/logback/core/net/server/RemoteLoggerServerListener.java
    A logback-core/src/main/java/ch/qos/logback/core/net/server/RemoteLoggerServerRunner.java
    A logback-core/src/main/java/ch/qos/logback/core/net/server/RemoteLoggerStreamClient.java
    A logback-core/src/main/java/ch/qos/logback/core/net/server/SSLServerSocketAppenderBase.java
    A logback-core/src/main/java/ch/qos/logback/core/net/server/ServerListener.java
    A logback-core/src/main/java/ch/qos/logback/core/net/server/ServerRunner.java
    A logback-core/src/main/java/ch/qos/logback/core/net/server/ServerSocketAppenderBase.java
    A logback-core/src/main/java/ch/qos/logback/core/net/server/ServerSocketListener.java
    A logback-core/src/main/java/ch/qos/logback/core/net/server/ThreadPoolFactoryBean.java
    A logback-core/src/main/java/ch/qos/logback/core/net/server/package.html
    R logback-core/src/test/java/ch/qos/logback/core/net/MockContext.java
    M logback-core/src/test/java/ch/qos/logback/core/net/SSLSocketAppenderBaseTest.java
    A logback-core/src/test/java/ch/qos/logback/core/net/mock/MockContext.java
    A logback-core/src/test/java/ch/qos/logback/core/net/server/ConcurrentServerRunnerTest.java
    A logback-core/src/test/java/ch/qos/logback/core/net/server/InstrumentedServerSocketAppenderBase.java
    A logback-core/src/test/java/ch/qos/logback/core/net/server/MockClient.java
    A logback-core/src/test/java/ch/qos/logback/core/net/server/MockClientVisitor.java
    A logback-core/src/test/java/ch/qos/logback/core/net/server/MockContext.java
    A logback-core/src/test/java/ch/qos/logback/core/net/server/MockEventQueue.java
    A logback-core/src/test/java/ch/qos/logback/core/net/server/MockServerListener.java
    A logback-core/src/test/java/ch/qos/logback/core/net/server/MockServerRunner.java
    A logback-core/src/test/java/ch/qos/logback/core/net/server/MockThreadPoolFactoryBean.java
    A logback-core/src/test/java/ch/qos/logback/core/net/server/RemoteLoggerStreamClientTest.java
    A logback-core/src/test/java/ch/qos/logback/core/net/server/SSLServerSocketAppenderBaseTest.java
    A logback-core/src/test/java/ch/qos/logback/core/net/server/ServerSocketAppenderBaseFunctionalTest.java
    A logback-core/src/test/java/ch/qos/logback/core/net/server/ServerSocketAppenderBaseTest.java
    A logback-core/src/test/java/ch/qos/logback/core/net/server/ServerSocketListenerTest.java
    A logback-core/src/test/java/ch/qos/logback/core/net/server/ServerSocketUtil.java

  Log Message:
  -----------
  Merge pull request #93 from ceharris/LOGBACK-822

LOGBACK-822: add ServerSocketAppenderBase and SSLServerSocketAppenderBase to core


Compare: https://github.com/qos-ch/logback/compare/30273b1b04a0...ce038c12261a


More information about the logback-dev mailing list