[logback-dev] [qos-ch/logback] 5c9917: removed unused SocketReceiver.createExecutorServic...

Carl Harris ceharris at vt.edu
Sun Apr 28 16:01:37 CEST 2013 

  Branch: refs/heads/LOGBACK-848
  Home:   https://github.com/qos-ch/logback
  Commit: 5c9917ce3fb08664bdf5d204892e2977df91e03b
      https://github.com/qos-ch/logback/commit/5c9917ce3fb08664bdf5d204892e2977df91e03b
  Author: Carl Harris <ceharris at vt.edu>
  Date:   2013-04-27 (Sat, 27 Apr 2013)

  Changed paths:
    M logback-classic/src/main/java/ch/qos/logback/classic/net/SocketReceiver.java

  Log Message:
  -----------
  removed unused SocketReceiver.createExecutorService


  Commit: e2164f9eb60b12d08500684b0a644c65b24df3f9
      https://github.com/qos-ch/logback/commit/e2164f9eb60b12d08500684b0a644c65b24df3f9
  Author: Carl Harris <ceharris at vt.edu>
  Date:   2013-04-27 (Sat, 27 Apr 2013)

  Changed paths:
    M logback-classic/src/main/java/ch/qos/logback/classic/net/SocketReceiver.java

  Log Message:
  -----------
  use "receiver" instead of "remote" in receiver diagnostic messages


  Commit: ac0dafdbac096eb51895d7243eeac9708cdcfad1
      https://github.com/qos-ch/logback/commit/ac0dafdbac096eb51895d7243eeac9708cdcfad1
  Author: Carl Harris <ceharris at vt.edu>
  Date:   2013-04-27 (Sat, 27 Apr 2013)

  Changed paths:
    M logback-access/src/main/java/ch/qos/logback/access/net/SSLSocketAppender.java
    M logback-access/src/main/java/ch/qos/logback/access/net/SocketAppender.java

  Log Message:
  -----------
  marked SocketAppender convenience constructors in access as deprecated

For consistency with logback-core.


  Commit: 298a3cac3a32d6b08380ae7c265c7222945155e1
      https://github.com/qos-ch/logback/commit/298a3cac3a32d6b08380ae7c265c7222945155e1
  Author: Carl Harris <ceharris at vt.edu>
  Date:   2013-04-28 (Sun, 28 Apr 2013)

  Changed paths:
    M logback-core/src/test/java/ch/qos/logback/core/net/mock/MockContext.java
    A logback-core/src/test/java/ch/qos/logback/core/net/mock/MockExecutorService.java
    M logback-core/src/test/java/ch/qos/logback/core/net/server/ConcurrentServerRunnerTest.java
    R logback-core/src/test/java/ch/qos/logback/core/net/server/MockContext.java
    R logback-core/src/test/java/ch/qos/logback/core/net/server/MockExecutorService.java
    M logback-core/src/test/java/ch/qos/logback/core/net/server/RemoteReceiverStreamClientTest.java
    M logback-core/src/test/java/ch/qos/logback/core/net/server/ServerSocketAppenderBaseFunctionalTest.java
    M logback-core/src/test/java/ch/qos/logback/core/net/server/ServerSocketAppenderBaseTest.java

  Log Message:
  -----------
  moved MockContext and MockExecutorService to ..core.net.mock


  Commit: 19e2a5564943adcf06b1aca3f44f261330251173
      https://github.com/qos-ch/logback/commit/19e2a5564943adcf06b1aca3f44f261330251173
  Author: Carl Harris <ceharris at vt.edu>
  Date:   2013-04-28 (Sun, 28 Apr 2013)

  Changed paths:
    M logback-core/src/test/java/ch/qos/logback/core/net/mock/MockExecutorService.java

  Log Message:
  -----------
  added missing doc comments to MockExecutorService


  Commit: 0a7a0b70b65bf7ab63f4cc9e8e0d54f748490506
      https://github.com/qos-ch/logback/commit/0a7a0b70b65bf7ab63f4cc9e8e0d54f748490506
  Author: Carl Harris <ceharris at vt.edu>
  Date:   2013-04-28 (Sun, 28 Apr 2013)

  Changed paths:
    M logback-classic/src/test/java/ch/qos/logback/classic/net/server/SSLServerSocketReceiverTest.java
    M logback-classic/src/test/java/ch/qos/logback/classic/net/server/ServerSocketReceiverTest.java

  Log Message:
  -----------
  fixed references to MockContext in test classes


  Commit: dcf6e324e92ae6b89bd3e7eb2032a44f254e8a6f
      https://github.com/qos-ch/logback/commit/dcf6e324e92ae6b89bd3e7eb2032a44f254e8a6f
  Author: Carl Harris <ceharris at vt.edu>
  Date:   2013-04-28 (Sun, 28 Apr 2013)

  Changed paths:
    R logback-access/src/test/java/ch/qos/logback/access/net/MockSocketServer.java
    M logback-access/src/test/java/ch/qos/logback/access/net/PackageTest.java
    R logback-access/src/test/java/ch/qos/logback/access/net/SocketAppenderTest.java
    M logback-classic/src/test/java/ch/qos/logback/classic/net/PackageTest.java
    R logback-classic/src/test/java/ch/qos/logback/classic/net/SocketAppenderTest.java

  Log Message:
  -----------
  removed old SocketAppenderTest from classic and access

These test classes were really testing SocketAppenderBase not
SocketAppender, per se.  The new implementation of SocketAppenderBase is
significantly different and will require a new unit test suite.


  Commit: 03fe4b00f95d3c15f10d25fe7f552a91da9d39f6
      https://github.com/qos-ch/logback/commit/03fe4b00f95d3c15f10d25fe7f552a91da9d39f6
  Author: Carl Harris <ceharris at vt.edu>
  Date:   2013-04-28 (Sun, 28 Apr 2013)

  Changed paths:
    M logback-core/src/main/java/ch/qos/logback/core/net/SSLSocketAppenderBase.java
    M logback-core/src/main/java/ch/qos/logback/core/net/SocketAppenderBase.java
    A logback-core/src/test/java/ch/qos/logback/core/net/SocketAppenderBaseTest.java

  Log Message:
  -----------
  improved SocketAppenderBase

SocketAppenderBase now uses SocketConnector for its (re-)connection
logic, and uses an asynchronous task to dispatch events to the remote
receiver.  A configurable queue is utilized to relay logging events from
the append method to the dispatch task.  When the queue length is zero
(the default), a SynchronousQueue is utilized, preserving the previous
appender behavior.  When the queue length is greater than zero, a
bounded queue is utilized, allowing the appender to efficiently drop
logging events when remote receiver (or network) cannot keep up with the
rate of logging events delivered to the appender.


  Commit: 16d67e508b953fe06b52356bf29f3a33ff1e3884
      https://github.com/qos-ch/logback/commit/16d67e508b953fe06b52356bf29f3a33ff1e3884
  Author: Carl Harris <ceharris at vt.edu>
  Date:   2013-04-28 (Sun, 28 Apr 2013)

  Changed paths:
    M logback-access/src/main/java/ch/qos/logback/access/net/SSLSocketAppender.java
    M logback-access/src/main/java/ch/qos/logback/access/net/SocketAppender.java
    M logback-classic/src/main/java/ch/qos/logback/classic/net/SSLSocketAppender.java
    M logback-classic/src/main/java/ch/qos/logback/classic/net/SocketAppender.java

  Log Message:
  -----------
  modified concrete appenders to use appropriate constructors

Mutable fields in SocketAppenderBase were previously exposed as
protected fields and modified by constructors in concrete subclasses.
This commit improves encapsulation of the base class by exposing
protected constructors for subclasses to invoke rather than directly
exposing the fields.  These new constructors are marked as deprecated,
as the convenience constructors on the base classes (which are also
deprecated) are the sole reason for their existence.  A future release
should remove all but the no-arg constructor from the base class and
subclasses.


Compare: https://github.com/qos-ch/logback/compare/55b5749d031d...16d67e508b95

More information about the logback-dev mailing list