[logback-dev] [qos-ch/logback] 495929: Added relativePath to parent.

Tony Trinh tony19 at gmail.com
Thu Apr 10 05:31:23 CEST 2014


Hi Ceki,

I agree. We don't need to set parent.relativePath to "../pom.xml",
especially since that setting is already the default value [1]. IMO, we
should keep the pom as simple as possible.

[1] http://maven.apache.org/ref/3.2.1/maven-model/maven.html#class_parent

Tony


On Wed, Apr 9, 2014 at 6:48 AM, Ceki Gulcu <ceki at qos.ch> wrote:

>
> Hi Joern,
>
> Many thanks for catching the version problem with the parent!
>
> Having said that I don't think we need the relative paths to the parent
> pom. Tony, what do you think?
>
> Cheers,
>
> --
> Ceki
>
>
> On 08.04.2014 23:46, Joern Huxhorn wrote:
>
>>    Branch: refs/heads/master
>>    Home:   https://github.com/qos-ch/logback
>>    Commit: 495929dc9620f1f0fbfcd8da73afaee16da946f2
>>        https://github.com/qos-ch/logback/commit/
>> 495929dc9620f1f0fbfcd8da73afaee16da946f2
>>    Author: Joern Huxhorn<jhuxhorn at googlemail.com>
>>    Date:   2014-04-08 (Tue, 08 Apr 2014)
>>
>>    Changed paths:
>>      M logback-access/pom.xml
>>      M logback-classic/pom.xml
>>      M logback-core/pom.xml
>>      M logback-examples/pom.xml
>>      M logback-site/pom.xml
>>
>>    Log Message:
>>    -----------
>>    Added relativePath to parent.
>>
>>
>>    Commit: 04868fab69732d1803a2b6672bccfcf7a2a5997f
>>        https://github.com/qos-ch/logback/commit/
>> 04868fab69732d1803a2b6672bccfcf7a2a5997f
>>    Author: Joern Huxhorn<jhuxhorn at googlemail.com>
>>    Date:   2014-04-08 (Tue, 08 Apr 2014)
>>
>>    Changed paths:
>>      M pom.xml
>>
>>    Log Message:
>>    -----------
>>    Fix build.
>>
>> Reverted parent version from 1.2.0 to 1.1.3 for now.
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.qos.ch/pipermail/logback-dev/attachments/20140409/a22bc510/attachment.html>


More information about the logback-dev mailing list