[logback-dev] [qos-ch/logback] 168836: Fix AsyncAppender/SocketAppender unit tests

Tony Trinh tony19 at gmail.com
Sat Jun 21 20:53:04 CEST 2014


  Branch: refs/heads/master
  Home:   https://github.com/qos-ch/logback
  Commit: 168836114313f70ce56a12da194a71034fcbb8bb
      https://github.com/qos-ch/logback/commit/168836114313f70ce56a12da194a71034fcbb8bb
  Author: Tony Trinh <tony19 at gmail.com>
  Date:   2014-06-21 (Sat, 21 Jun 2014)

  Changed paths:
    M logback-core/src/test/java/ch/qos/logback/core/AsyncAppenderBaseTest.java
    M logback-core/src/test/java/ch/qos/logback/core/net/AbstractSocketAppenderIntegrationTest.java
    M logback-core/src/test/java/ch/qos/logback/core/net/AbstractSocketAppenderTest.java

  Log Message:
  -----------
  Fix AsyncAppender/SocketAppender unit tests

AsyncAppenderBaseTest: The appender was not allowed enough time to
flush the appender on #stop(), causing the empty-check of the appender's
queue to fail. The test appender's max-flush time is now extended from
30ms to >1000ms.

AbstractSocketAppenderIntegrationTest: A unit test expected
deque.takeFirst() to be called only once after a log-event is appended,
but the call actually occurs twice in a while-loop, where the second
call is intended to block, waiting for the next log-event.

AbstractSocketAppenderTest: A unit test that verified appender
behavior when its deque was at capacity neglected to fill the deque
before testing for errors.




More information about the logback-dev mailing list