[logback-dev] [JIRA] (LOGBACK-1445) Joran's PropertySetter::addBasicProperty doesn't work when the basic property followsTheValueOfConvention

[QOS.CH (JIRA)]

Steve Lessard created LOGBACK-1445:
--------------------------------------

             Summary: Joran's PropertySetter::addBasicProperty doesn't work when the basic property followsTheValueOfConvention
                 Key: LOGBACK-1445
                 URL: https://jira.qos.ch/browse/LOGBACK-1445
             Project: logback
          Issue Type: Bug
          Components: Joran
    Affects Versions: 1.3.0-alpha4
            Reporter: Steve Lessard
            Assignee: Logback dev list


The Joran code for supporting custom properties goes to great lengths to ensure that a basic property can be created from a string. In particular Joran supports basic properties where the type of the property is a class containing a `public static valueOf(String str)`. Joran will go through lots of checks before creating an instance of this class (via the valueOf) method and then, at the last second, not use that class instance at all and try to call the property setter with the original string. Naturally, since the setter is expecting specific class instance and not a String instance the call fails with an InvalidArgumentException. The fix is actually quite simple and is contained in this pull request:  https://github.com/qos-ch/logback/pull/442



--
This message was sent by Atlassian JIRA
(v7.3.1#73012)