<style>
/* Changing the layout to use less space for mobiles */
@media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) {
#email-body { min-width: 30em !important; }
#email-page { padding: 8px !important; }
#email-banner { padding: 8px 8px 0 8px !important; }
#email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; }
#email-fields { padding: 0 8px 8px 8px !important; }
#email-gutter { width: 0 !important; }
}
</style>
<div id="email-body">
<table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;">
<tr valign="top">
<td id="email-page" style="padding:16px !important;">
<table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;">
<tr valign="top">
<td bgcolor="#003366" style="background-color:#003366;color:#ffffff;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img src="http://jira.qos.ch/s/en_USet69y6/731/19/_/jira-logo-scaled.png" alt="" style="vertical-align:top;" /></td>
</tr><tr valign="top">
<td id="email-banner" style="padding:32px 32px 0 32px;">
<table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%;">
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;">
<img id="email-avatar" src="http://jira.qos.ch/secure/useravatar?avatarId=10122" alt="" height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px 16px 0;" />
<div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;">
<a class="user-hover" rel="dtonhofer" id="email_dtonhofer" href="http://jira.qos.ch/secure/ViewProfile.jspa?name=dtonhofer" style="color:#326ca6;">David Tonhofer</a>
created <img src="http://jira.qos.ch/images/icons/bug.gif" height="16" width="16" border="0" align="absmiddle" alt="Bug"> <a style='color:#326ca6;text-decoration:none;' href='http://jira.qos.ch/browse/LOGBACK-791'>LOGBACK-791</a>
</div>
<div id="email-summary" style="font-size:16px;line-height:20px;padding:2px 0 16px 0;">
<a style='color:#326ca6;text-decoration:none;' href='http://jira.qos.ch/browse/LOGBACK-791'><strong>Design issue: Should an OnConsoleStatusListener be addable to the StatusManager if there already is one?</strong></a>
</div>
</td>
</tr>
</table>
</td>
</tr>
<tr valign="top">
<td id="email-fields" style="padding:0 32px 32px 32px;">
<table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;" width="100%">
<tr valign="top">
<td id="email-gutter" style="width:64px;white-space:nowrap;"></td>
<td>
<table border="0" cellpadding="0" cellspacing="0" width="100%">
<tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Issue Type:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
<img src="http://jira.qos.ch/images/icons/bug.gif" height="16" width="16" border="0" align="absmiddle" alt="Bug"> Bug
</td>
</tr> <tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Assignee:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
<a class="user-hover" rel="logback-dev@qos.ch" id="email_logback-dev@qos.ch" href="http://jira.qos.ch/secure/ViewProfile.jspa?name=logback-dev%40qos.ch" style="color:#326ca6;">Logback dev list</a>
</td>
</tr> <tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Created:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
01/Jan/13 11:48 PM
</td>
</tr> <tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Description:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
- We configure logback through logback.xml
<br/>
<br/>
- Initial, pre-configuration state of logback has an "OnConsoleStatusListener" set up.
<br/>
<br/>
In effect, if I understand what I see in the debugger, once the "configuration" tag is encountered, the following call stack happens:
<br/>
<br/>
Interpreter.startElement() calls
<br/>
Interpreter.callBeginAction() calls
<br/>
ConfigurationAction.begin() calls
<br/>
OnConsoleStatusListener.addNewInstanceToContext(context);
<br/>
<br/>
which creates a new OnConsoleStatusListener, starts it, then adds it to the StatusManager reachable via the context.
<br/>
<br/>
At the moment, the first messages appear on the Console as the "retrospective" is printed out if the messages in there are not too old.
<br/>
<br/>
Now:
<br/>
<br/>
If logback.xml contains
<br/>
<br/>
<statusListener class="ch.qos.logback.core.status.OnConsoleStatusListener" />
<br/>
<br/>
then a second OnConsoleStatusListener instance will be added to the StatusManager reachable via the context.
<br/>
<br/>
This leads to a confusing duplication of messages. First all the retrospective, which may have grown since the first printout, is printed. All subsequent status messages are then printed, too.
<br/>
<br/>
Would it not be better to check in
<br/>
<br/>
OnConsoleStatusListener.addNewInstanceToContext(Context context)
<br/>
<br/>
whether a OnConsoleStatusListener already exists in the StatusManager (in this case, the ch.qos.logback.core.BasicStatusManager) and do nothing if that is so?
<br/>
<br/>
This is a special handling of OnConsoleStatusListener, of course, barring some more general idea (like a flag on the listener saying "I am responsible for the console and there can be only one").
<br/>
<br/>
There is the nasty problem that the new OnConsoleStatusListener must not be started before we are sure it could be added, because starting makes it print out the retrospective. But start() is not in the interface of StatusListener. :-(
<br/>
<br/>
This thus seems to demand that BasicStatusManager.add() is specially tuned to OnConsoleStatusListener:
<br/>
<br/>
-------------
<br/>
public void add(StatusListener listener) {
<br/>
if (listener != null) {
<br/>
synchronized (statusListenerListLock) {
<br/>
boolean addIt = true;
<br/>
// Check that there is no OnConsoleStatusListener already
<br/>
// If not, start it before adding it
<br/>
if (listener instanceof OnConsoleStatusListener) {
<br/>
for (StatusListener cur : statusListenerList) {
<br/>
if (cur instanceof OnConsoleStatusListener) {
<br/>
addIt = false;
<br/>
break;
<br/>
}
<br/>
}
<br/>
if (addIt) {
<br/>
((OnConsoleStatusListener) listener).start();
<br/>
}
<br/>
}
<br/>
if (addIt) {
<br/>
statusListenerList.add(listener);
<br/>
}
<br/>
}
<br/>
}
<br/>
}
<br/>
--------
<br/>
<br/>
<br/>
And that OnConsoleStatusListener leave "start()" to the "add()" method. This is not fully nice, because the hidden assumption is that the StatusManager returned by the Context is indeed a BasicStatusManager. The correct solution would be to have start() defined on StatusListener and call the add() method addAndStart(), but that would change the interface:
<br/>
<br/>
--------
<br/>
static public void addNewInstanceToContext(Context context) {
<br/>
OnConsoleStatusListener onConsoleStatusListener = new OnConsoleStatusListener();
<br/>
onConsoleStatusListener.setContext(context);
<br/>
// onConsoleStatusListener.start();
<br/>
context.getStatusManager().add(onConsoleStatusListener);
<br/>
}
<br/>
--------
<br/>
<br/>
</td>
</tr>
<tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Project:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
<a style="color:#326ca6;" href="http://jira.qos.ch/browse/LOGBACK">logback</a>
</td>
</tr> <tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Priority:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
<img src="http://jira.qos.ch/images/icons/priority_major.gif" height="16" width="16" border="0" align="absmiddle" alt="Major"> Major
</td>
</tr> <tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Reporter:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
<a class="user-hover" rel="dtonhofer" id="email_dtonhofer" href="http://jira.qos.ch/secure/ViewProfile.jspa?name=dtonhofer" style="color:#326ca6;">David Tonhofer</a>
</td>
</tr> </table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td><!-- End #email-page -->
</tr>
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: 0 16px 16px 16px;text-align:center;">
This message is automatically generated by JIRA.<br />
If you think it was sent incorrectly, please contact your <a style='color:#326ca6;' href='http://jira.qos.ch/secure/ContactAdministrators!default.jspa'>JIRA administrators</a>.<br />
For more information on JIRA, see: <a style='color:#326ca6;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a>
</td>
</tr>
</table><!-- End #email-wrap -->
</div><!-- End #email-body -->