<style>
/* Changing the layout to use less space for mobiles */
@media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) {
#email-body { min-width: 30em !important; }
#email-page { padding: 8px !important; }
#email-banner { padding: 8px 8px 0 8px !important; }
#email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; }
#email-fields { padding: 0 8px 8px 8px !important; }
#email-gutter { width: 0 !important; }
}
</style>
<div id="email-body">
<table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;">
<tr valign="top">
<td id="email-page" style="padding:16px !important;">
<table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;">
<tr valign="top">
<td bgcolor="#003366" style="background-color:#003366;color:#ffffff;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img src="http://jira.qos.ch/s/en_USet69y6/731/19/_/jira-logo-scaled.png" alt="" style="vertical-align:top;" /></td>
</tr><tr valign="top">
<td id="email-banner" style="padding:32px 32px 0 32px;">
<table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%;">
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;">
<img id="email-avatar" src="http://jira.qos.ch/secure/useravatar?avatarId=10122" alt="" height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px 16px 0;" />
<div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;">
<a class="user-hover" rel="dtonhofer" id="email_dtonhofer" href="http://jira.qos.ch/secure/ViewProfile.jspa?name=dtonhofer" style="color:#326ca6;">David Tonhofer</a>
commented on <img src="http://jira.qos.ch/images/icons/bug.gif" height="16" width="16" border="0" align="absmiddle" alt="Bug"> <a style='color:#326ca6;text-decoration:none;' href='http://jira.qos.ch/browse/LOGBACK-791'>LOGBACK-791</a>
</div>
<div id="email-summary" style="font-size:16px;line-height:20px;padding:2px 0 16px 0;">
<a style='color:#326ca6;text-decoration:none;' href='http://jira.qos.ch/browse/LOGBACK-791'><strong>Design issue: Should an OnConsoleStatusListener be addable to the StatusManager if there already is one?</strong></a>
</div>
</td>
</tr>
</table>
</td>
</tr>
<tr valign="top">
<td id="email-fields" style="padding:0 32px 32px 32px;">
<table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;" width="100%">
<tr valign="top">
<td id="email-gutter" style="width:64px;white-space:nowrap;"></td>
<td>
<table border="0" cellpadding="0" cellspacing="0" width="100%">
<tr valign="top">
<td colspan="2" style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 16px 0;width:100%;">
<div class="comment-block" style="background-color:#edf5ff;border:1px solid #dddddd;color:#000000;padding:12px;">Aha! Missed one! It looks like OnConsoleStatusListener can be started
<br/>
<br/>
1) at the start of SAX Event "configuration" with call stack:
<br/>
<br/>
JoranConfigurator.doConfigure(URL)
<br/>
JoranConfigurator.doConfigure(InputStream)
<br/>
JoranConfigurator.doConfigure(InputSource)
<br/>
JoranConfigurator.doConfigure(List<SaxEvent>)
<br/>
EventPlayer.play(List<SaxEvent>)
<br/>
Interpreter.startElement(StartEvent)
<br/>
Interpreter.startElement(String, String, String, Attributes)
<br/>
Interpreter.callBeginAction(List, String, Attributes)
<br/>
ConfigurationAction.begin(InterpretationContext, String, Attributes)
<br/>
OnConsoleStatusListener.addNewInstanceToContext(Context)
<br/>
BasicStatusManager.add(StatusListener) --- which due to the modification above calls...
<br/>
OnConsoleStatusListener.start()
<br/>
OnConsoleStatusListener(OnPrintStreamStatusListenerBase).start()
<br/>
<br/>
2) at the *end* of SAX event "statusListener" because "OnConsoleStatusListener" implements "LifeCycle", with call stack:
<br/>
<br/>
JoranConfigurator.doConfigure(URL)
<br/>
JoranConfigurator.doConfigure(InputStream)
<br/>
JoranConfigurator.doConfigure(InputSource)
<br/>
JoranConfigurator.doConfigure(List<SaxEvent>)
<br/>
EventPlayer.play(List<SaxEvent>)
<br/>
Interpreter.endElement(StartEvent)
<br/>
Interpreter.endElement(String, String, String)
<br/>
Interpreter.callEndAction(List, String)
<br/>
StatusListenerAction.end(InterpretationContext, String) -- "if (statusListener instanceof LifeCycle) { ((LifeCycle) statusListener).start(); }"
<br/>
OnConsoleStatusListener.start()
<br/>
OnConsoleStatusListener(OnPrintStreamStatusListenerBase).start()
<br/>
<br/>
....This means that even if not "added" to the StatusManager, the "OnConsoleStatusListener" will print its retrospective ...
<br/>
<br/>
Change of plan:
<br/>
<br/>
Add a boolean to "OnPrintStreamStatusListenerBase" that says whether the "retrospective" should be printed on "start()",
<br/>
and check its value in "start()":
<br/>
<br/>
-----------
<br/>
<br/>
abstract class OnPrintStreamStatusListenerBase {
<br/>
<br/>
private boolean printRetrospectiveOnStart = true;
<br/>
public void setPrintRetrospectiveOnStart(boolean x) { printRetrospectiveOnStart = x; }
<br/>
public void start() { isStarted = true; if (retrospective > 0 && printRetrospectiveOnStart) { retrospectivePrint(); } }
<br/>
<br/>
----------
<br/>
<br/>
Then BasicStatusManager.addIt() is coded as follows:
<br/>
<br/>
-----------
<br/>
<br/>
public void add(StatusListener listener) {
<br/>
<br/>
if (listener != null) {
<br/>
synchronized (statusListenerListLock) {
<br/>
boolean addIt = true;
<br/>
// Check that there is no OnConsoleStatusListener already
<br/>
// If tere is not, start it (calling Lifecycle.start()) before adding it
<br/>
if (listener instanceof OnConsoleStatusListener) {
<br/>
for (StatusListener cur : statusListenerList) {
<br/>
if (cur instanceof OnConsoleStatusListener) {
<br/>
addIt = false; break;
<br/>
}
<br/>
}
<br/>
// always "start" but only "print retrospective" if "addIt"
<br/>
OnConsoleStatusListener ocl = (OnConsoleStatusListener) listener;
<br/>
ocl.setPrintRetrospectiveOnStart(addIt);
<br/>
ocl.start();
<br/>
}
<br/>
if (addIt) { statusListenerList.add(listener); }
<br/>
}
<br/>
}
<br/>
}
<br/>
<br/>
-----------
<br/>
<br/>
</div>
<div style="color:#505050;padding:4px 0 0 0;"> </div>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td><!-- End #email-page -->
</tr>
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: 0 16px 16px 16px;text-align:center;">
This message is automatically generated by JIRA.<br />
If you think it was sent incorrectly, please contact your <a style='color:#326ca6;' href='http://jira.qos.ch/secure/ContactAdministrators!default.jspa'>JIRA administrators</a>.<br />
For more information on JIRA, see: <a style='color:#326ca6;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a>
</td>
</tr>
</table><!-- End #email-wrap -->
</div><!-- End #email-body -->