<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Arial,Helvetica,sans-serif;" dir="ltr">
<p>The set of appenders provided by the main Logback project includes implementations for nine vendor-specific database products. The target audience for each of these database appenders is significantly smaller than the target audience for the TestNG Reporter
appender provided by this PR. </p>
<p><br>
</p>
<p>In a recent survey of dependency references in GitHub, the TestNG library comes in at #20 on the list of the top 100 most frequently used libraries. The only database flavor that comes close to this level of popularity is MySQL, which came in at #26. HSQL
comes in at #54, and the remaining SQL flavors didn't make it onto the Top 100 list.</p>
<p><br>
</p>
<p>I can migrate the TestNG Reporter appender to a companion project without the need to duplicate core unit test classes, by adding a "test-jar" dependency to my Maven project. While this is functional, it's less than ideal, as it makes this appender more
difficult for potential users to find.</p>
<p><br>
</p>
<p>Does any of these factors tip the balance in favor of incorporating this new appender into the main Logback project?</p>
<br>
<div style="color: rgb(0, 0, 0);">
<div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> logback-dev <logback-dev-bounces@qos.ch> on behalf of Ceki Gülcü <ceki@qos.ch><br>
<b>Sent:</b> Wednesday, January 11, 2017 1:00 PM<br>
<b>To:</b> logback developers list<br>
<b>Subject:</b> Re: [logback-dev] Logback PR #352: Add appender for TestNG Reporter</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt;">
<div class="PlainText">Hi Scoot,<br>
<br>
Thank you for posting your question on this list.<br>
<br>
ReporterAppender is probably not useful enough for a wider audience. As <br>
such, I do not think it is advisable to incorporate it into logback proper.<br>
<br>
Best regards,<br>
<br>
--<br>
Ceki<br>
<br>
On 1/11/2017 21:29, Scott Babcock wrote:<br>
> Hi!<br>
><br>
><br>
> My PR #352 (<a href="https://github.com/qos-ch/logback/pull/352" id="LPlnk682466" previewremoved="true">https://github.com/qos-ch/logback/pull/352</a>) was closed,<br>
> stating that it’s not generic enough. Given that TestNG is the most<br>
> widely used Java testing framework in the world, how much more generic<br>
> does a Logback logger need to be for it to be included in the mainline<br>
> project?<br>
><br>
><br>
><br>
> The primary challenge with spinning this up as a separate project is<br>
> that much of the basic building blocks for developing loggers and unit<br>
> tests haven’t been defined or published in a form that facilitates<br>
> extension and importation of these existing declarations. Consequently,<br>
> it’s necessary to duplicate a significant volume of the implementation<br>
> from the mainline project into the companion logger project. This is<br>
> terribly inefficient and exposes the external project to the risk of<br>
> breakage as revisions are applied to the mainline project that aren’t<br>
> automatically picked up by the companion project.<br>
><br>
><br>
><br>
> Please advise.<br>
><br>
><br>
><br>
> Thanks!<br>
><br>
> = Scott Babcock =<br>
><br>
><br>
_______________________________________________<br>
logback-dev mailing list<br>
logback-dev@qos.ch<br>
<a href="http://mailman.qos.ch/mailman/listinfo/logback-dev" id="LPlnk267976" previewremoved="true">http://mailman.qos.ch/mailman/listinfo/logback-dev</a></div>
</span></font></div>
</div>
</body>
</html>