<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=utf-8"><meta name=Generator content="Microsoft Word 15 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p.MsoPlainText, li.MsoPlainText, div.MsoPlainText
{mso-style-priority:99;
mso-style-link:"Tekst zonder opmaak Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
span.TekstzonderopmaakChar
{mso-style-name:"Tekst zonder opmaak Char";
mso-style-priority:99;
mso-style-link:"Tekst zonder opmaak";
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style></head><body lang=NL link="#0563C1" vlink="#954F72"><div class=WordSection1><p class=MsoPlainText><span lang=EN-GB>Hi all, </span></p><p class=MsoPlainText><span lang=EN-GB><o:p> </o:p></span></p><p class=MsoPlainText><span lang=EN-GB>I'm trying to change the behaviour of the SyslogAppender. One of the things I'd like is short hostnames and I’m not the only one: </span></p><p class=MsoPlainText><span lang=EN-GB><a href="http://logback.10977.n7.nabble.com/Syslog-Appender-Short-Host-Name-td1102.html">http://logback.10977.n7.nabble.com/Syslog-Appender-Short-Host-Name-td1102.html</a></span></p><p class=MsoPlainText><span lang=EN-GB><a href="https://github.com/qos-ch/logback/pull/139/files">https://github.com/qos-ch/logback/pull/139/files</a></span></p><p class=MsoPlainText><span lang=EN-GB><a href="https://jira.qos.ch/browse/LOGBACK-1011">https://jira.qos.ch/browse/LOGBACK-1011</a> </span></p><p class=MsoPlainText><span lang=EN-GB><o:p> </o:p></span></p><p class=MsoPlainText><span lang=EN-GB>I find that this is really hard and struggle to understand why. There are a couple of things that make this hard, in my opinion: </span></p><p class=MsoPlainText><span lang=EN-GB>1. You can't set a Layout on a SyslogAppender. (as long as this is the case, you might as well remove the null check in start())</span></p><p class=MsoPlainText><span lang=EN-GB> public void setLayout(Layout<E> layout) {</span></p><p class=MsoPlainText><span lang=EN-GB> addWarn("The layout of a SyslogAppender cannot be set directly. See also " + SYSLOG_LAYOUT_URL);</span></p><p class=MsoPlainText><span lang=EN-GB> }</span></p><p class=MsoPlainText><span lang=EN-GB>2. Both the Layout and the stackTraceLayout use (independent) instanceConverterMap to add the SyslogConverter. If the converter had been set to the defaults or the context I could override it. </span></p><p class=MsoPlainText><span lang=EN-GB><o:p> </o:p></span></p><p class=MsoPlainText><span lang=EN-GB>While I can supply a patch, I'm curious if this was a deliberate decision. Also I’m not quite clear on what the responsibilities of the SyslogAppenderBase vs the SyslogAppender are. What should happen in the base and what should be left for the implementation?<o:p></o:p></span></p><p class=MsoPlainText><span lang=EN-GB><o:p> </o:p></span></p><p class=MsoPlainText><span lang=EN-GB>Having it like this it's hard to e.g. create a converter that is compliant with rfc5424, or support other behaviours. </span></p><p class=MsoPlainText><span lang=EN-GB>There are a number of attempts/issues for the RFC5424; </span></p><p class=MsoPlainText><span lang=EN-GB><a href="https://jira.qos.ch/browse/LOGBACK-588">https://jira.qos.ch/browse/LOGBACK-588</a></span></p><p class=MsoPlainText><span lang=EN-GB><a href="https://github.com/qos-ch/logback/pull/72/files">https://github.com/qos-ch/logback/pull/72/files</a> </span></p><p class=MsoPlainText><span lang=EN-GB><o:p> </o:p></span></p><p class=MsoPlainText><span lang=EN-GB>Any thoughts?</span></p><p class=MsoPlainText><span lang=EN-GB><o:p> </o:p></span></p><p class=MsoPlainText><span lang=EN-GB>Groeten,</span></p><p class=MsoPlainText><span lang=EN-GB><o:p> </o:p></span></p><p class=MsoPlainText><span lang=EN-GB>Friso</span></p><p class=MsoNormal><o:p> </o:p></p></div></body></html>