<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://jira.qos.ch">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="cid:jira-generated-image-avatar-40b143e4-dc48-41dd-901a-e83d063b0462" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="sdoktorovich@pros.com" id="email_sdoktorovich@pros.com" href="https://jira.qos.ch/secure/ViewProfile.jspa?name=sdoktorovich%40pros.com" style="color:#3b73af;; color: #3b73af; text-decoration: none">Stanislav Doktorovich</a> <strong>commented</strong> on <a href="https://jira.qos.ch/browse/LOGBACK-995" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-62411dee-2577-446d-8117-733ed26687a5" height="16" width="16" border="0" align="absmiddle" alt="Bug"> LOGBACK-995</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://jira.qos.ch/browse/LOGBACK-995" style="color: #3b73af; text-decoration: none">Re: Standalone rollover gets exception</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-pattern" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; border-bottom: none; padding-bottom: 0" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0px; border-collapse: collapse; padding: 0 0 10px 0">
<div class="code panel" style="border-width: 1px;; border: 1px solid #cccccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #cccccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; margin-top: 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
<span class="code-keyword" style="color: #000091">public</span> class ManualRolloverTest
{
@BeforeClass
<span class="code-keyword" style="color: #000091">public</span> <span class="code-keyword" style="color: #000091">static</span> void configureLogback()
{
<span class="code-comment" style="color: #808080">// assume SLF4J is bound to logback in the current environment
</span> LoggerContext context = (LoggerContext) LoggerFactory.getILoggerFactory();
<span class="code-keyword" style="color: #000091">try</span>
{
JoranConfigurator configurator = <span class="code-keyword" style="color: #000091">new</span> JoranConfigurator();
configurator.setContext(context);
<span class="code-comment" style="color: #808080">// Call context.reset() to clear any previous configuration, e.g. <span class="code-keyword" style="color: #000091; color: #808080">default</span>
</span> <span class="code-comment" style="color: #808080">// configuration. For multi-step configuration, omit calling context.reset().
</span> context.reset();
<span class="code-object" style="color: #910091">String</span> config = <span class="code-quote" style="color: #009100">"<configuration debug=\"</span><span class="code-keyword" style="color: #000091">false</span>\<span class="code-quote" style="color: #009100">" scan=\"</span><span class="code-keyword" style="color: #000091">false</span>\<span class="code-quote" style="color: #009100">">\n"</span> +
<span class="code-quote" style="color: #009100">" <appender name=\"</span>FILE\<span class="code-quote" style="color: #009100">" class=\"</span>ch.qos.logback.core.rolling.RollingFileAppender\<span class="code-quote" style="color: #009100">">\n"</span> +
<span class="code-quote" style="color: #009100">" <file>1.log</file>\n"</span> +
<span class="code-quote" style="color: #009100">" <rollingPolicy class=\"</span>ch.qos.logback.core.rolling.TimeBasedRollingPolicy\<span class="code-quote" style="color: #009100">">\n"</span> +
<span class="code-quote" style="color: #009100">" <!-- daily rollover -->\n"</span> +
<span class="code-quote" style="color: #009100">" <fileNamePattern>1.log.%d{yyyyMMdd}</fileNamePattern>\n"</span> +
<span class="code-quote" style="color: #009100">" <maxHistory>3</maxHistory>\n"</span> +
<span class="code-quote" style="color: #009100">" <totalSizeCap>1GB</totalSizeCap>\n"</span> +
<span class="code-quote" style="color: #009100">" </rollingPolicy>\n"</span> +
<span class="code-quote" style="color: #009100">" </appender>\n"</span> +
<span class="code-quote" style="color: #009100">" <root level=\"</span>INFO\<span class="code-quote" style="color: #009100">">\n"</span> +
<span class="code-quote" style="color: #009100">" <appender-ref ref=\"</span>FILE\<span class="code-quote" style="color: #009100">" />\n"</span> +
<span class="code-quote" style="color: #009100">" </root>\n"</span> +
<span class="code-quote" style="color: #009100">"</configuration>"</span>;
configurator.doConfigure(<span class="code-keyword" style="color: #000091">new</span> ByteArrayInputStream(config.getBytes()));
}
<span class="code-keyword" style="color: #000091">catch</span> (JoranException je)
{
<span class="code-comment" style="color: #808080">// StatusPrinter will handle <span class="code-keyword" style="color: #000091; color: #808080">this</span>
</span> }
StatusPrinter.printInCaseOfErrorsOrWarnings(context);
}
@Test
<span class="code-keyword" style="color: #000091">public</span> void checkManualRolloverDoesNotThrowNPE() <span class="code-keyword" style="color: #000091">throws</span> Exception
{
<span class="code-comment" style="color: #808080">// assume SLF4J is bound to logback in the current environment
</span> LoggerContext loggerContext = (LoggerContext) LoggerFactory.getILoggerFactory();
Logger logger = loggerContext.getLogger(org.slf4j.Logger.ROOT_LOGGER_NAME);
rollover(logger.iteratorForAppenders());
}
<span class="code-keyword" style="color: #000091">private</span> <span class="code-keyword" style="color: #000091">static</span> void rollover(Iterator<Appender<ILoggingEvent>> it)
{
<span class="code-keyword" style="color: #000091">for</span> (; it.hasNext(); )
{
Appender<ILoggingEvent> appender = it.next();
<span class="code-keyword" style="color: #000091">if</span> (appender <span class="code-keyword" style="color: #000091">instanceof</span> RollingFileAppender)
{
RollingFileAppender rollingFileAppender = (RollingFileAppender) appender;
rollingFileAppender.rollover();
}
<span class="code-keyword" style="color: #000091">else</span> <span class="code-keyword" style="color: #000091">if</span> (appender <span class="code-keyword" style="color: #000091">instanceof</span> AsyncAppender)
{
AsyncAppender asyncAppender = (AsyncAppender) appender;
rollover(asyncAppender.iteratorForAppenders());
}
}
}
}
</pre>
</div>
</div> <p style="margin: 10px 0 0 0"> </p> <p style="margin: 10px 0 0 0">Here is the unit test.</p> <p style="margin: 10px 0 0 0"> </p> <p style="margin: 10px 0 0 0">The issue is that </p> <p style="margin: 10px 0 0 0">TimeBasedFileNamingAndTriggeringPolicyBase.elapsedPeriodsFileName is null at startup time until DefaultTimeBasedFileNamingAndTriggeringPolicy.isTriggeringEvent is called at least once.</p> <p style="margin: 10px 0 0 0"> </p> <p style="margin: 10px 0 0 0">I'm not aware with logback architecture good enough to provide a patch, but it could be as simple as doing </p> <p style="margin: 10px 0 0 0">elapsedPeriodsFileName = tbrp.fileNamePatternWithoutCompSuffix.convert(getCurrentTime()); </p> <p style="margin: 10px 0 0 0">in start() method.</p> <p style="margin: 10px 0 0 0"> </p> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0px; vertical-align: middle"> <a href="https://jira.qos.ch/browse/LOGBACK-995#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-a2ead27f-bc03-4cfb-b0e0-547fe5f9cad5" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://jira.qos.ch/browse/LOGBACK-995#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian JIRA <span id="footer-build-information">(v7.3.1#73012-<span title="68837e38d8ed1b069612405186dcdceed665bb39" data-commit-id="68837e38d8ed1b069612405186dcdceed665bb39}">sha1:68837e3</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-bd3a44ff-35ca-45c0-a27a-2fb84cdf55b5" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
</body>
</html>