<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://jira.qos.ch">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="cid:jira-generated-image-avatar-bdcd4826-f318-4575-9f59-3e415791c333" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="plinyar" id="email_plinyar" href="https://jira.qos.ch/secure/ViewProfile.jspa?name=plinyar" style="color:#3b73af;; color: #3b73af; text-decoration: none">Roman Koreshkov</a> <strong>commented</strong> on <a href="https://jira.qos.ch/browse/LOGBACK-1016" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-09640656-f5f8-47ad-b183-f168aaadf5d7" height="16" width="16" border="0" align="absmiddle" alt="New Feature"> LOGBACK-1016</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://jira.qos.ch/browse/LOGBACK-1016" style="color: #3b73af; text-decoration: none">Re: logback-access: Enable MDC support</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-pattern" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; border-bottom: none; padding-bottom: 0" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0px; border-collapse: collapse; padding: 0 0 10px 0"> <p style="margin: 10px 0 0 0; margin-top: 0">I ended up creating my own JsonProvider. See below (code in kotlin):</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #cccccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #cccccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; margin-top: 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
<span class="code-keyword" style="color: #000091">import</span> ch.qos.logback.access.spi.IAccessEvent
<span class="code-keyword" style="color: #000091">import</span> ch.qos.logback.classic.util.LogbackMDCAdapter
<span class="code-keyword" style="color: #000091">import</span> com.fasterxml.jackson.core.JsonGenerator
<span class="code-keyword" style="color: #000091">import</span> net.logstash.logback.composite.AbstractFieldJsonProvider
<span class="code-keyword" style="color: #000091">import</span> net.logstash.logback.composite.FieldNamesAware
<span class="code-keyword" style="color: #000091">import</span> net.logstash.logback.composite.JsonWritingUtils
<span class="code-keyword" style="color: #000091">import</span> net.logstash.logback.fieldnames.LogstashAccessFieldNames
<span class="code-keyword" style="color: #000091">import</span> org.slf4j.MDC
<span class="code-keyword" style="color: #000091">import</span> java.io.IOException
<span class="code-keyword" style="color: #000091">import</span> java.util.*
class AccessMdcProvider : AbstractFieldJsonProvider<IAccessEvent>(), FieldNamesAware<LogstashAccessFieldNames> {
<span class="code-keyword" style="color: #000091">private</span> <span class="code-keyword" style="color: #000091">var</span> includeMdcKeyNames: MutableList<<span class="code-object" style="color: #910091">String</span>> = ArrayList()
<span class="code-keyword" style="color: #000091">private</span> <span class="code-keyword" style="color: #000091">var</span> excludeMdcKeyNames: MutableList<<span class="code-object" style="color: #910091">String</span>> = ArrayList()
override fun start() {
<span class="code-keyword" style="color: #000091">if</span> (!<span class="code-keyword" style="color: #000091">this</span>.includeMdcKeyNames.isEmpty() && !<span class="code-keyword" style="color: #000091">this</span>.excludeMdcKeyNames.isEmpty()) {
addError(<span class="code-quote" style="color: #009100">"Both includeMdcKeyNames and excludeMdcKeyNames are not empty. Only one is allowed to be not empty."</span>)
}
<span class="code-keyword" style="color: #000091">super</span>.start()
}
@Throws(IOException::class)
override fun writeTo(generator: JsonGenerator, event: IAccessEvent) {
val mdcProperties = getMDCPropertyMap().takeIf { it.isNotEmpty() }?.let { props ->
<span class="code-keyword" style="color: #000091">if</span> (!includeMdcKeyNames.isEmpty()) {
props.toMutableMap().also { it.keys.retainAll(includeMdcKeyNames) }
} <span class="code-keyword" style="color: #000091">else</span> <span class="code-keyword" style="color: #000091">if</span> (!excludeMdcKeyNames.isEmpty()) {
props.toMutableMap().also { it.keys.removeAll(excludeMdcKeyNames) }
} <span class="code-keyword" style="color: #000091">else</span>
props
}
mdcProperties?.also {
<span class="code-keyword" style="color: #000091">if</span> (fieldName != <span class="code-keyword" style="color: #000091">null</span>) {
generator.writeObjectFieldStart(fieldName)
}
JsonWritingUtils.writeMapEntries(generator, it)
<span class="code-keyword" style="color: #000091">if</span> (fieldName != <span class="code-keyword" style="color: #000091">null</span>) {
generator.writeEndObject()
}
}
}
<span class="code-keyword" style="color: #000091">private</span> fun getMDCPropertyMap(): Map<<span class="code-object" style="color: #910091">String</span>, <span class="code-object" style="color: #910091">String</span>> {
<span class="code-comment" style="color: #808080">// populate mdcPropertyMap <span class="code-keyword" style="color: #000091; color: #808080">if</span> <span class="code-keyword" style="color: #000091; color: #808080">null</span>
</span> val mdcPropertyMap = MDC.getMDCAdapter().let { mdc->
<span class="code-keyword" style="color: #000091">if</span> (mdc is LogbackMDCAdapter)
mdc.propertyMap
<span class="code-keyword" style="color: #000091">else</span>
mdc.copyOfContextMap
} ?: emptyMap<<span class="code-object" style="color: #910091">String</span>, <span class="code-object" style="color: #910091">String</span>>()
<span class="code-keyword" style="color: #000091">return</span> mdcPropertyMap
}
override fun setFieldNames(fieldNames: LogstashAccessFieldNames) {
<span class="code-comment" style="color: #808080">//fieldName = fieldNames.mdc
</span> }
fun getIncludeMdcKeyNames(): List<<span class="code-object" style="color: #910091">String</span>> {
<span class="code-keyword" style="color: #000091">return</span> Collections.unmodifiableList(includeMdcKeyNames)
}
fun addIncludeMdcKeyName(includedMdcKeyName: <span class="code-object" style="color: #910091">String</span>) {
<span class="code-keyword" style="color: #000091">this</span>.includeMdcKeyNames.add(includedMdcKeyName)
}
fun setIncludeMdcKeyNames(includeMdcKeyNames: List<<span class="code-object" style="color: #910091">String</span>>) {
<span class="code-keyword" style="color: #000091">this</span>.includeMdcKeyNames = ArrayList(includeMdcKeyNames)
}
fun getExcludeMdcKeyNames(): List<<span class="code-object" style="color: #910091">String</span>> {
<span class="code-keyword" style="color: #000091">return</span> Collections.unmodifiableList(excludeMdcKeyNames)
}
fun addExcludeMdcKeyName(excludedMdcKeyName: <span class="code-object" style="color: #910091">String</span>) {
<span class="code-keyword" style="color: #000091">this</span>.excludeMdcKeyNames.add(excludedMdcKeyName)
}
fun setExcludeMdcKeyNames(excludeMdcKeyNames: List<<span class="code-object" style="color: #910091">String</span>>) {
<span class="code-keyword" style="color: #000091">this</span>.excludeMdcKeyNames = ArrayList(excludeMdcKeyNames)
}
}
</pre>
</div>
</div> <p style="margin: 10px 0 0 0">, and attached it to my CompositeJsonEncoder:</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #cccccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #cccccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; margin-top: 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
<span class="code-keyword" style="color: #000091">import</span> ch.qos.logback.access.spi.IAccessEvent
<span class="code-keyword" style="color: #000091">import</span> net.logstash.logback.LogstashAccessFormatter
<span class="code-keyword" style="color: #000091">import</span> net.logstash.logback.composite.CompositeJsonFormatter
<span class="code-keyword" style="color: #000091">import</span> net.logstash.logback.encoder.CompositeJsonEncoder
class AccessEncoder : CompositeJsonEncoder<IAccessEvent>() {
override fun createFormatter(): CompositeJsonFormatter<IAccessEvent> =
LogstashAccessFormatter(<span class="code-keyword" style="color: #000091">this</span>).also {
it.providers.addProvider(AccessMdcProvider())
}
}
</pre>
</div>
</div> <p style="margin: 10px 0 0 0">, and used it in logback.xml:</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #cccccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #cccccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; margin-top: 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
<configuration>
<appender name=<span class="code-quote" style="color: #009100">"ACCESS_FILE"</span> class=<span class="code-quote" style="color: #009100">"ch.qos.logback.core.rolling.RollingFileAppender"</span>>
...
<encoder class=<span class="code-quote" style="color: #009100">"mynamespace.AccessEncoder"</span>/>
</appender>
</pre>
</div>
</div> <p style="margin: 10px 0 0 0"> </p> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0px; vertical-align: middle"> <a href="https://jira.qos.ch/browse/LOGBACK-1016#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-b5c62b9c-e151-41f5-8dee-a5f8acd9eea3" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://jira.qos.ch/browse/LOGBACK-1016#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian JIRA <span id="footer-build-information">(v7.3.1#73012-<span title="68837e38d8ed1b069612405186dcdceed665bb39" data-commit-id="68837e38d8ed1b069612405186dcdceed665bb39}">sha1:68837e3</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-519dcb51-3742-416a-b175-3d499ce302cd" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
</body>
</html>