<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://jira.qos.ch">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="cid:jira-generated-image-avatar-0b96c443-f55c-456a-8c92-5dcdad20077d" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="zimmi" id="email_zimmi" href="https://jira.qos.ch/secure/ViewProfile.jspa?name=zimmi" style="color:#3b73af;; color: #3b73af; text-decoration: none">Thomas Zimmermann</a> <strong>commented</strong> on <a href="https://jira.qos.ch/browse/LOGBACK-1385" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-c93f4696-71a6-4c83-9631-bcbd078da36f" height="16" width="16" border="0" align="absmiddle" alt="Bug"> LOGBACK-1385</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://jira.qos.ch/browse/LOGBACK-1385" style="color: #3b73af; text-decoration: none">Re: JPMS: exports ch.qos.logback.core.rolling</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-pattern" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; border-bottom: none; padding-bottom: 0" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0px; border-collapse: collapse; padding: 0 0 10px 0"> <p style="margin: 10px 0 0 0; margin-top: 0">@<a href="https://jira.qos.ch/secure/ViewProfile.jspa?name=Armengedon" class="user-hover" rel="Armengedon" style="color: #3b73af; text-decoration: none">Jordi Armengol Bosch</a></p> <p style="margin: 10px 0 0 0">Sorry for the late answer, I haven't checked ma mail in a while. I remember having an issue as well, but can't exactly remember if it was the same as yours however. I think some parameter type was wrong so reflection couldn't find the correct method, so that seems to match. I'll paste my working code below, I hope that helps!</p> <p style="margin: 10px 0 0 0"> </p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #cccccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #cccccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; margin-top: 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
<span class="code-keyword" style="color: #000091">package</span> org.example;
<span class="code-keyword" style="color: #000091">import</span> ch.qos.logback.classic.Level;
<span class="code-keyword" style="color: #000091">import</span> ch.qos.logback.classic.Logger;
<span class="code-keyword" style="color: #000091">import</span> ch.qos.logback.classic.LoggerContext;
<span class="code-keyword" style="color: #000091">import</span> ch.qos.logback.classic.encoder.PatternLayoutEncoder;
<span class="code-keyword" style="color: #000091">import</span> ch.qos.logback.classic.spi.Configurator;
<span class="code-keyword" style="color: #000091">import</span> ch.qos.logback.classic.spi.ILoggingEvent;
<span class="code-keyword" style="color: #000091">import</span> ch.qos.logback.core.Appender;
<span class="code-keyword" style="color: #000091">import</span> ch.qos.logback.core.ConsoleAppender;
<span class="code-keyword" style="color: #000091">import</span> ch.qos.logback.core.Context;
<span class="code-keyword" style="color: #000091">import</span> ch.qos.logback.core.FileAppender;
<span class="code-keyword" style="color: #000091">import</span> ch.qos.logback.core.joran.util.PropertySetter;
<span class="code-keyword" style="color: #000091">import</span> ch.qos.logback.core.spi.ContextAware;
<span class="code-keyword" style="color: #000091">import</span> ch.qos.logback.core.spi.ContextAwareBase;
<span class="code-keyword" style="color: #000091">import</span> ch.qos.logback.core.spi.LifeCycle;
<span class="code-keyword" style="color: #000091">import</span> ch.qos.logback.core.util.DynamicClassLoadingException;
<span class="code-keyword" style="color: #000091">import</span> ch.qos.logback.core.util.FileSize;
<span class="code-keyword" style="color: #000091">import</span> ch.qos.logback.core.util.IncompatibleClassException;
<span class="code-keyword" style="color: #000091">import</span> ch.qos.logback.core.util.OptionHelper;
<span class="code-keyword" style="color: #000091">import</span> java.io.File;
<span class="code-keyword" style="color: #000091">import</span> java.nio.file.Path;
/**
* Configures logging. We <span class="code-keyword" style="color: #000091">do</span> it <span class="code-keyword" style="color: #000091">this</span> way because reading the XML files is really
* slow (over half a second on startup).
*
* @author thomas
*/
<span class="code-keyword" style="color: #000091">public</span> class LogbackConfigurator <span class="code-keyword" style="color: #000091">extends</span> ContextAwareBase <span class="code-keyword" style="color: #000091">implements</span> Configurator {
@Override
<span class="code-keyword" style="color: #000091">public</span> void configure(LoggerContext context) {
Level level;
Appender<ILoggingEvent> appender;
<span class="code-keyword" style="color: #000091">if</span> (Main.isDevelopmentEnvironment()) {
level = Level.INFO;
appender = devAppender(context);
} <span class="code-keyword" style="color: #000091">else</span> {
level = Level.INFO;
<span class="code-keyword" style="color: #000091">var</span> logDir = Main.appDirectory().resolve(<span class="code-quote" style="color: #009100">"logs"</span>);
appender = prodAppender(context, logDir);
}
<span class="code-keyword" style="color: #000091">var</span> root = context.getLogger(Logger.ROOT_LOGGER_NAME);
root.setLevel(level);
root.addAppender(appender);
}
<span class="code-keyword" style="color: #000091">private</span> <span class="code-keyword" style="color: #000091">static</span> Appender<ILoggingEvent> devAppender(LoggerContext context) {
<span class="code-keyword" style="color: #000091">var</span> console = <span class="code-keyword" style="color: #000091">new</span> ConsoleAppender<ILoggingEvent>();
console.setContext(context);
console.setName(<span class="code-quote" style="color: #009100">"STDOUT"</span>);
console.setEncoder(encoder(context));
console.start();
<span class="code-keyword" style="color: #000091">return</span> console;
}
<span class="code-keyword" style="color: #000091">private</span> <span class="code-keyword" style="color: #000091">static</span> Appender<ILoggingEvent> prodAppender(LoggerContext context, Path logDir) {
<span class="code-comment" style="color: #808080">// Package ch.qos.logback.core.rolling is not exported, so we have to resort to reflection hacks.
</span> <span class="code-comment" style="color: #808080">// See: https://jira.qos.ch/browse/LOGBACK-1385
</span> <span class="code-keyword" style="color: #000091">try</span> {
<span class="code-keyword" style="color: #000091">var</span> cacheClassName = <span class="code-quote" style="color: #009100">"ch.qos.logback.core.joran.util.beans.BeanDescriptionCache"</span>;
<span class="code-keyword" style="color: #000091">var</span> cache = OptionHelper.instantiateByClassNameAndParameter(cacheClassName, <span class="code-object" style="color: #910091">Object</span>.class, context, Context.class, context);
<span class="code-keyword" style="color: #000091">var</span> setterParams = <span class="code-keyword" style="color: #000091">new</span> <span class="code-object" style="color: #910091">Class</span><?>[]{cache.getClass(), <span class="code-object" style="color: #910091">Object</span>.class};
<span class="code-keyword" style="color: #000091">var</span> setterConstructor = PropertySetter.class.getConstructor(setterParams);
<span class="code-keyword" style="color: #000091">var</span> rollingClassName = <span class="code-quote" style="color: #009100">"ch.qos.logback.core.rolling.RollingFileAppender"</span>;
@SuppressWarnings(<span class="code-quote" style="color: #009100">"unchecked"</span>)
<span class="code-keyword" style="color: #000091">var</span> rolling = (FileAppender<ILoggingEvent>) OptionHelper.instantiateByClassName(rollingClassName, FileAppender.class, context);
<span class="code-keyword" style="color: #000091">var</span> rollingSetter = setterConstructor.newInstance(cache, rolling);
rollingSetter.setContext(context);
rolling.setContext(context);
rolling.setName(<span class="code-quote" style="color: #009100">"ROLLING"</span>);
<span class="code-keyword" style="color: #000091">var</span> policyClassName = <span class="code-quote" style="color: #009100">"ch.qos.logback.core.rolling.TimeBasedRollingPolicy"</span>;
<span class="code-keyword" style="color: #000091">var</span> policy = (ContextAware & LifeCycle) OptionHelper.instantiateByClassName(policyClassName, ContextAware.class, context);
<span class="code-keyword" style="color: #000091">var</span> policySetter = setterConstructor.newInstance(cache, policy);
policySetter.setContext(context);
policy.setContext(context);
<span class="code-comment" style="color: #808080">// rolling policies need to know their parent
</span> <span class="code-comment" style="color: #808080">// it's one of the rare cases, where a sub-component knows about its parent
</span> policySetter.setComplexProperty(<span class="code-quote" style="color: #009100">"parent"</span>, rolling);
<span class="code-keyword" style="color: #000091">var</span> pattern = <span class="code-quote" style="color: #009100">"%d{yyyy-MM-dd}.log.zip"</span>;
policySetter.setComplexProperty(<span class="code-quote" style="color: #009100">"fileNamePattern"</span>, logDir.toString() + File.separatorChar + pattern);
policySetter.setProperty(<span class="code-quote" style="color: #009100">"maxHistory"</span>, <span class="code-quote" style="color: #009100">"3"</span>);
policySetter.setComplexProperty(<span class="code-quote" style="color: #009100">"totalSizeCap"</span>, FileSize.valueOf(<span class="code-quote" style="color: #009100">"10MB"</span>));
policySetter.setProperty(<span class="code-quote" style="color: #009100">"cleanHistoryOnStart"</span>, <span class="code-quote" style="color: #009100">"<span class="code-keyword" style="color: #000091; color: #009100">true</span>"</span>);
policy.start();
rollingSetter.setComplexProperty(<span class="code-quote" style="color: #009100">"rollingPolicy"</span>, policy);
rolling.setEncoder(encoder(context));
rolling.start();
<span class="code-keyword" style="color: #000091">return</span> rolling;
} <span class="code-keyword" style="color: #000091">catch</span> (IncompatibleClassException | DynamicClassLoadingException | ReflectiveOperationException ex) {
<span class="code-keyword" style="color: #000091">throw</span> <span class="code-keyword" style="color: #000091">new</span> RuntimeException(ex);
}
}
<span class="code-keyword" style="color: #000091">private</span> <span class="code-keyword" style="color: #000091">static</span> PatternLayoutEncoder encoder(LoggerContext context) {
<span class="code-keyword" style="color: #000091">var</span> encoder = <span class="code-keyword" style="color: #000091">new</span> PatternLayoutEncoder();
encoder.setContext(context);
encoder.setPattern(<span class="code-quote" style="color: #009100">"%d{yyyy-MM-dd'T'HH:mm:ss.SSSZ} [%thread] %-5level %logger{36} - %msg%n"</span>);
encoder.start();
<span class="code-keyword" style="color: #000091">return</span> encoder;
}
}
</pre>
</div>
</div> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0px; vertical-align: middle"> <a href="https://jira.qos.ch/browse/LOGBACK-1385#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-3376404d-a533-4f9f-b525-06ac3b9e0fde" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://jira.qos.ch/browse/LOGBACK-1385#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian JIRA <span id="footer-build-information">(v7.3.1#73012-<span title="68837e38d8ed1b069612405186dcdceed665bb39" data-commit-id="68837e38d8ed1b069612405186dcdceed665bb39}">sha1:68837e3</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-3238a019-3b83-4558-a4ba-015de0bc8589" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
</body>
</html>