<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://jira.qos.ch">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="cid:jira-generated-image-avatar-ae0b8d4e-8865-42a1-90f7-a3b78db3c897" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="joakime" id="email_joakime" href="https://jira.qos.ch/secure/ViewProfile.jspa?name=joakime" style="color:#3b73af;; color: #3b73af; text-decoration: none">Joakim Erdfelt</a> <strong>commented</strong> on <a href="https://jira.qos.ch/browse/LOGBACK-1027" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-c7da17a2-9683-4c80-be62-a86be647a0fc" height="16" width="16" border="0" align="absmiddle" alt="Bug"> LOGBACK-1027</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://jira.qos.ch/browse/LOGBACK-1027" style="color: #3b73af; text-decoration: none">Re: Circular Referenced Suppressed Exception Throws StackOverflowError</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-pattern" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; border-bottom: none; padding-bottom: 0" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0px; border-collapse: collapse; padding: 0 0 10px 0"> <p style="margin: 10px 0 0 0; margin-top: 0">Eclipse Jetty hit this issue as well.<br> Looks like OpenJDK 8u252 and OpenJDK 11.0.7 both have circular suppressed exception loops within their TLS layer.</p> <p style="margin: 10px 0 0 0">Circular Exception references are supported by the JVM's own <tt>Throwable.printStackTrace()</tt>, so we feel that logback should support them as well. (note: this is only a bug on logback, other slf4j implementations do not have this issue).</p> <p style="margin: 10px 0 0 0">In Jetty we worked out a hack with our community for a custom logback <tt>TurboFilter</tt> that can be used to hack around this bug in logback.</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #cccccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #cccccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; margin-top: 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
<span class="code-keyword" style="color: #000091">package</span> org.eclipse.jetty.logbackhack;
<span class="code-keyword" style="color: #000091">import</span> java.io.IOException;
<span class="code-keyword" style="color: #000091">import</span> java.io.PrintWriter;
<span class="code-keyword" style="color: #000091">import</span> java.io.StringWriter;
<span class="code-keyword" style="color: #000091">import</span> java.util.HashSet;
<span class="code-keyword" style="color: #000091">import</span> java.util.Set;
<span class="code-keyword" style="color: #000091">import</span> ch.qos.logback.classic.Level;
<span class="code-keyword" style="color: #000091">import</span> ch.qos.logback.classic.Logger;
<span class="code-keyword" style="color: #000091">import</span> ch.qos.logback.classic.turbo.TurboFilter;
<span class="code-keyword" style="color: #000091">import</span> ch.qos.logback.core.spi.FilterReply;
<span class="code-keyword" style="color: #000091">import</span> org.slf4j.LoggerFactory;
<span class="code-keyword" style="color: #000091">import</span> org.slf4j.Marker;
<span class="code-keyword" style="color: #000091">public</span> class RecursiveThrowableFixTurboFilter <span class="code-keyword" style="color: #000091">extends</span> TurboFilter
{
<span class="code-keyword" style="color: #000091">public</span> <span class="code-keyword" style="color: #000091">static</span> void init()
{
ch.qos.logback.classic.Logger rootLogger = (ch.qos.logback.classic.Logger)LoggerFactory.getLogger(org.slf4j.Logger.ROOT_LOGGER_NAME);
rootLogger.getLoggerContext().addTurboFilter(<span class="code-keyword" style="color: #000091">new</span> RecursiveThrowableFixTurboFilter());
}
@Override
<span class="code-keyword" style="color: #000091">public</span> FilterReply decide(Marker marker, Logger logger, Level level, <span class="code-object" style="color: #910091">String</span> format, <span class="code-object" style="color: #910091">Object</span>[] params, Throwable cause)
{
<span class="code-keyword" style="color: #000091">if</span> (hasRecursiveThrowableReference(cause, <span class="code-keyword" style="color: #000091">null</span>))
{
<span class="code-object" style="color: #910091">int</span> locationAwareLoggerInteger = Level.toLocationAwareLoggerInteger(level);
logger.log(marker, logger.getName(), locationAwareLoggerInteger, format, params, <span class="code-keyword" style="color: #000091">new</span> SafeException(cause));
<span class="code-keyword" style="color: #000091">return</span> FilterReply.DENY;
}
<span class="code-keyword" style="color: #000091">return</span> FilterReply.NEUTRAL;
}
<span class="code-keyword" style="color: #000091">private</span> <span class="code-object" style="color: #910091">boolean</span> hasRecursiveThrowableReference(Throwable cause, Set<Throwable> seen)
{
<span class="code-keyword" style="color: #000091">if</span> (cause == <span class="code-keyword" style="color: #000091">null</span>)
<span class="code-keyword" style="color: #000091">return</span> <span class="code-keyword" style="color: #000091">false</span>;
<span class="code-keyword" style="color: #000091">if</span> (seen == <span class="code-keyword" style="color: #000091">null</span>)
{
seen = <span class="code-keyword" style="color: #000091">new</span> HashSet<>();
}
<span class="code-keyword" style="color: #000091">else</span> <span class="code-keyword" style="color: #000091">if</span> (!seen.add(cause))
{
<span class="code-keyword" style="color: #000091">return</span> <span class="code-keyword" style="color: #000091">true</span>;
}
<span class="code-keyword" style="color: #000091">for</span> (Throwable suppressed : cause.getSuppressed())
{
<span class="code-keyword" style="color: #000091">if</span> (hasRecursiveThrowableReference(suppressed, seen))
{
<span class="code-keyword" style="color: #000091">return</span> <span class="code-keyword" style="color: #000091">true</span>;
}
}
<span class="code-keyword" style="color: #000091">return</span> hasRecursiveThrowableReference(cause.getCause(), seen);
}
<span class="code-keyword" style="color: #000091">public</span> <span class="code-keyword" style="color: #000091">static</span> <span class="code-object" style="color: #910091">String</span> toStackTrace(Throwable cause)
{
<span class="code-keyword" style="color: #000091">try</span> (StringWriter sw = <span class="code-keyword" style="color: #000091">new</span> StringWriter();
PrintWriter pw = <span class="code-keyword" style="color: #000091">new</span> PrintWriter(sw))
{
cause.printStackTrace(pw);
<span class="code-keyword" style="color: #000091">return</span> sw.toString();
}
<span class="code-keyword" style="color: #000091">catch</span> (IOException e)
{
<span class="code-keyword" style="color: #000091">return</span> <span class="code-quote" style="color: #009100">"Unable to produce Stacktrace <span class="code-keyword" style="color: #000091; color: #009100">for</span> "</span> + cause;
}
}
<span class="code-keyword" style="color: #000091">public</span> <span class="code-keyword" style="color: #000091">static</span> class SafeException <span class="code-keyword" style="color: #000091">extends</span> RuntimeException
{
<span class="code-keyword" style="color: #000091">public</span> SafeException(Throwable cause)
{
<span class="code-keyword" style="color: #000091">super</span>(toStackTrace(cause));
}
}
}
</pre>
</div>
</div> <p style="margin: 10px 0 0 0">We would appreciate a fix in the logback 1.2.x series (seeing as logback 1.3.x is all about radical API changes for slf4j 2.x)</p> <p style="margin: 10px 0 0 0">If the existing PR at <a href="https://github.com/qos-ch/logback/pull/399" class="external-link" rel="nofollow" style="color: #3b73af; text-decoration: none">https://github.com/qos-ch/logback/pull/399</a> isn't suitable. Let us know, and we'll submit our own PR for a solution for this.</p> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0px; vertical-align: middle"> <a href="https://jira.qos.ch/browse/LOGBACK-1027#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-33e78172-9516-4ec7-a69c-79c91dfb9c6c" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://jira.qos.ch/browse/LOGBACK-1027#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian JIRA <span id="footer-build-information">(v7.3.1#73012-<span title="68837e38d8ed1b069612405186dcdceed665bb39" data-commit-id="68837e38d8ed1b069612405186dcdceed665bb39}">sha1:68837e3</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-a71fd2a9-3dfe-41d4-88dc-795576fb7fe1" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
</body>
</html>