<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://jira.qos.ch">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0" bgcolor="#f5f5f5"> <!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="cid:jira-generated-image-avatar-7cd62625-03a7-4fb1-beeb-99f96716dc8d" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="christian.habermehl" id="email_christian.habermehl" href="https://jira.qos.ch/secure/ViewProfile.jspa?name=christian.habermehl" style="color:#0052cc;; color: #3b73af; text-decoration: none">Christian Habermehl</a> <strong>commented</strong> on <a href="https://jira.qos.ch/browse/LOGBACK-1754" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-7595f687-c683-4f27-b4c5-f368eaf5ab0d" height="16" width="16" border="0" align="absmiddle" alt="Bug"> LOGBACK-1754</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; border-spacing: 0; border-collapse: separate">
<tbody>
<tr> <!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td style="vertical-align: top;; padding: 0; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://jira.qos.ch/browse/LOGBACK-1754" style="color: #3b73af; text-decoration: none">Re: OverlappingFileLockException when using prudent mode</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-pattern" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; border-bottom: none; padding-bottom: 0" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0; border-collapse: collapse; padding: 0 0 10px"> <p style="margin: 10px 0 0; margin-top: 0">Sorry, I just found out, that I used CountDownLatch incorrectly. This test should work as axpected (all threads wait until latch fires)</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #cccccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #cccccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0; margin-top: 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
/*
* Logback: the reliable, <span class="code-keyword" style="color: #000091">generic</span>, fast and flexible logging framework.
* Copyright (C) 1999-2023, QOS.ch. All rights reserved.
*
* This program and the accompanying materials are dual-licensed under
* either the terms of the Eclipse Public License v1.0 as published by
* the Eclipse Foundation
*
* or (per the licensee's choosing)
*
* under the terms of the GNU Lesser General Public License version 2.1
* as published by the Free Software Foundation.
*/
<span class="code-keyword" style="color: #000091">package</span> ch.qos.logback.core.util;
<span class="code-keyword" style="color: #000091">import</span> <span class="code-keyword" style="color: #000091">static</span> org.junit.jupiter.api.Assertions.assertEquals;
<span class="code-keyword" style="color: #000091">import</span> <span class="code-keyword" style="color: #000091">static</span> org.junit.jupiter.api.Assertions.fail;
<span class="code-keyword" style="color: #000091">import</span> java.io.File;
<span class="code-keyword" style="color: #000091">import</span> java.io.IOException;
<span class="code-keyword" style="color: #000091">import</span> java.nio.file.Files;
<span class="code-keyword" style="color: #000091">import</span> java.util.ArrayList;
<span class="code-keyword" style="color: #000091">import</span> java.util.List;
<span class="code-keyword" style="color: #000091">import</span> java.util.concurrent.CountDownLatch;
<span class="code-keyword" style="color: #000091">import</span> org.junit.jupiter.api.BeforeEach;
<span class="code-keyword" style="color: #000091">import</span> org.junit.jupiter.api.Test;
<span class="code-keyword" style="color: #000091">import</span> ch.qos.logback.core.Context;
<span class="code-keyword" style="color: #000091">import</span> ch.qos.logback.core.ContextBase;
<span class="code-keyword" style="color: #000091">import</span> ch.qos.logback.core.FileAppender;
<span class="code-keyword" style="color: #000091">import</span> ch.qos.logback.core.encoder.EchoEncoder;
<span class="code-keyword" style="color: #000091">import</span> ch.qos.logback.core.status.testUtil.StatusChecker;
<span class="code-keyword" style="color: #000091">import</span> ch.qos.logback.core.testUtil.CoreTestConstants;
<span class="code-keyword" style="color: #000091">import</span> ch.qos.logback.core.testUtil.RandomUtil;
<span class="code-keyword" style="color: #000091">public</span> <span class="code-keyword" style="color: #000091">class </span>PrudentModeTest {
FileAppender<<span class="code-object" style="color: #910091">Object</span>> fa = <span class="code-keyword" style="color: #000091">new</span> FileAppender<<span class="code-object" style="color: #910091">Object</span>>();
Context context = <span class="code-keyword" style="color: #000091">new</span> ContextBase();
StatusChecker statusChecker = <span class="code-keyword" style="color: #000091">new</span> StatusChecker(context);
<span class="code-object" style="color: #910091">int</span> diff = RandomUtil.getPositiveInt();
<span class="code-object" style="color: #910091">String</span> outputDirStr = CoreTestConstants.OUTPUT_DIR_PREFIX + <span class="code-quote" style="color: #009100">"prudentLockTest-"</span> + diff + <span class="code-quote" style="color: #009100">"/"</span>;
<span class="code-object" style="color: #910091">String</span> logfileStr = outputDirStr + <span class="code-quote" style="color: #009100">"output.log"</span>;
<span class="code-keyword" style="color: #000091">private</span> <span class="code-keyword" style="color: #000091">static</span> <span class="code-keyword" style="color: #000091">final</span> <span class="code-object" style="color: #910091">int</span> THREAD_COUNT = 8;
<span class="code-keyword" style="color: #000091">private</span> <span class="code-keyword" style="color: #000091">static</span> <span class="code-keyword" style="color: #000091">final</span> <span class="code-object" style="color: #910091">int</span> LOOP_COUNT = 100 / THREAD_COUNT;
@BeforeEach
<span class="code-keyword" style="color: #000091">public</span> void beforeEach() {
File outputDir = <span class="code-keyword" style="color: #000091">new</span> File(outputDirStr);
<span class="code-keyword" style="color: #000091">if</span> (!outputDir.mkdirs()) {
fail(<span class="code-quote" style="color: #009100">"failed to create folder "</span> + outputDir);
}
fa.setContext(context);
fa.setName(<span class="code-quote" style="color: #009100">"FILE"</span>);
fa.setPrudent(<span class="code-keyword" style="color: #000091">true</span>);
fa.setEncoder(<span class="code-keyword" style="color: #000091">new</span> EchoEncoder<<span class="code-object" style="color: #910091">Object</span>>());
fa.setFile(logfileStr);
fa.start();
}
<span class="code-comment" style="color: #808080">// see https://jira.qos.ch/browse/LOGBACK-1754
</span> @Test
<span class="code-keyword" style="color: #000091">public</span> void assertNoOverlappingFileLockException() <span class="code-keyword" style="color: #000091">throws</span> IOException {
CountDownLatch latch = <span class="code-keyword" style="color: #000091">new</span> CountDownLatch(1);
List<<span class="code-object" style="color: #910091">Thread</span>> threads = <span class="code-keyword" style="color: #000091">new</span> ArrayList<>(THREAD_COUNT);
<span class="code-keyword" style="color: #000091">for</span> (<span class="code-object" style="color: #910091">int</span> i = 0; i < THREAD_COUNT; i++) {
LoggerThread thread = <span class="code-keyword" style="color: #000091">new</span> LoggerThread(latch, <span class="code-quote" style="color: #009100">"message from thread "</span> + i);
thread.start();
threads.add(thread);
}
latch.countDown();
<span class="code-object" style="color: #910091">int</span> i = 0;
<span class="code-keyword" style="color: #000091">for</span> (<span class="code-object" style="color: #910091">Thread</span> thread : threads) {
<span class="code-keyword" style="color: #000091">try</span> {
thread.join();
} <span class="code-keyword" style="color: #000091">catch</span> (InterruptedException e) {
e.printStackTrace();
}
}
StatusPrinter.print(context);
statusChecker.assertIsWarningOrErrorFree();
fa.stop();
File file = <span class="code-keyword" style="color: #000091">new</span> File(logfileStr);
List<<span class="code-object" style="color: #910091">String</span>> allLines = Files.readAllLines(file.toPath());
<span class="code-object" style="color: #910091">int</span> actualLineCount = allLines.size();
assertEquals(LOOP_COUNT * THREAD_COUNT, actualLineCount, <span class="code-quote" style="color: #009100">"unexpected line count "</span> + actualLineCount);
}
<span class="code-keyword" style="color: #000091">class </span>LoggerThread <span class="code-keyword" style="color: #000091">extends</span> <span class="code-object" style="color: #910091">Thread</span> {
<span class="code-keyword" style="color: #000091">private</span> <span class="code-keyword" style="color: #000091">final</span> CountDownLatch latch;
<span class="code-keyword" style="color: #000091">private</span> <span class="code-keyword" style="color: #000091">final</span> <span class="code-object" style="color: #910091">String</span> message;
LoggerThread(CountDownLatch latch, <span class="code-object" style="color: #910091">String</span> message) {
setDaemon(<span class="code-keyword" style="color: #000091">false</span>);
<span class="code-keyword" style="color: #000091">this</span>.latch = latch;
<span class="code-keyword" style="color: #000091">this</span>.message = message;
}
@Override
<span class="code-keyword" style="color: #000091">public</span> void run() {
<span class="code-keyword" style="color: #000091">try</span> {
latch.await();
<span class="code-keyword" style="color: #000091">for</span> (<span class="code-object" style="color: #910091">int</span> i = 0; i < LOOP_COUNT; i++) {
<span class="code-keyword" style="color: #000091">if</span> ((i & 0x08) == 0) {
<span class="code-comment" style="color: #808080">// yield to spice it up
</span> <span class="code-object" style="color: #910091">Thread</span>.yield();
}
PrudentModeTest.<span class="code-keyword" style="color: #000091">this</span>.fa.doAppend(message + <span class="code-quote" style="color: #009100">" i="</span> + i);
}
} <span class="code-keyword" style="color: #000091">catch</span> (InterruptedException ex) {
<span class="code-object" style="color: #910091">Thread</span>.currentThread().interrupt();
}
}
void delay(<span class="code-object" style="color: #910091">long</span> millis) {
<span class="code-keyword" style="color: #000091">try</span> {
<span class="code-object" style="color: #910091">Thread</span>.sleep(millis);
} <span class="code-keyword" style="color: #000091">catch</span> (InterruptedException e) {
<span class="code-keyword" style="color: #000091">throw</span> <span class="code-keyword" style="color: #000091">new</span> RuntimeException(e);
}
}
}
}
</pre>
</div>
</div> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://jira.qos.ch/browse/LOGBACK-1754#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-fab6ea95-634c-4b23-b30a-538b418d7017" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://jira.qos.ch/browse/LOGBACK-1754#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr> <!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian Jira <span id="footer-build-information">(v9.6.0#960000-<span title="a3ee8af5f2c25a3620f1c8a480ceeacbd2cd7740" data-commit-id="a3ee8af5f2c25a3620f1c8a480ceeacbd2cd7740}">sha1:a3ee8af</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="https://jira.qos.ch/images/mail/atlassian-email-logo.png" alt="Atlassian logo" title="Atlassian logo" width="191" height="24" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
</body>
</html>