[logback-user] SiftingAppender and RollingFileAppender, roll on close.

[diroussel]

Thomas,

That functionality looks good.  

In order to get accepted, maybe you can make your changes to
AppenderTrackerImpl less invasive?

In AppenderTrackerImpl, you are subclassing LinkedHashMap instead of using
ch.qos.logback.classic.pattern.LRUCache.  But really there is no need for a
map. Just keep the existing head and tail references, keep a count
variablle. If the count gets to high, then remove entries from the tail.

I like that you've added unit tests and the code formatting is consistent
with the rest of the code base.

David



--
View this message in context: http://logback.10977.n7.nabble.com/SiftingAppender-and-RollingFileAppender-roll-on-close-tp11840p11862.html
Sent from the Users mailing list archive at Nabble.com.