[slf4j-dev] Benefits of Message objects?

[Ralph Goers]

On Sep 10, 2011, at 3:31 PM, Ceki Gülcü wrote:

> On 10/09/2011 10:47 PM, Ralph Goers wrote:
>> 
>> On Sep 10, 2011, at 12:50 PM, Ceki Gülcü wrote:
>>> 
>>> 
>>> > I should also note that at some point LocationAwareLogger wasn't
>>> > even passing the argument array so EventLogger had to convert the
>>> > EventData to an XML String. When you added the argument array to
>>> > LocationAwareLogger you modified EventLogger to pass a null, not the
>>> > EventData object. So using EventLogger is very expensive.
>>> 
>>> It would be trivial to correct EventLogger wouldn't it?
>> 
>> It would have before you switched to git :- ) - I lost my commit privs
>> when you did that.
> 
> I am sorry about for offhandedly taking away your commit privileges to slf4j-ext during the move to git. I incorrectly assumed git's features, i.e. forking and sending pull requests, were a substitute for svn commit privileges. I meant no offense.

It wasn't a matter of being offended - I knew it wasn't personal. But it was/is a significant barrier to participation. It meant that, in effect, I had/have to get your permission to commit anything. I'm not a big fan of Review-Then-Commit so I'm even less a fan of commit and hope its promoted.

In effect, this is exactly why I think it has taken the ASF so long to incorporate git as an alternate source control system.

Ralph