[slf4j-dev] Several improvements in MessageFormatter

Ceki Gülcü ceki at qos.ch
Mon Feb 20 11:19:54 CET 2017

Hi Nikolay,

Thank for the PR. However, there's too much in it.  Cosmetic changes 
that touch many lines take me too much time to verify for little added 
value. Given my workload, I'm not interested in this PR ad it stands.

I would suggest that you propose a single change, the one you deem most 
valuable. This should be relatively easy to do.

Alternatively, if you wish to make the exercise more interesting and 
valuable, I would propose a single pass implementation of the formatting 
algorithm which should improve performance. See lines 125 to 168 of 
StrawLog.java [1]. The resulting performance improvement  should be 
benchmarked to validate improved performance. Otherwise, the change is 
not worth the trouble.

Please let me know what you think.



On 2/19/2017 22:12, Николай Федоровских wrote:
> Hi All,
> I made some optimizations in MessageFormatter such as: avoid redundant
> instantiations, replace HashMap to IdentityHashMap, reduce checks for
> arrays args, etc.
> PR: https://github.com/qos-ch/slf4j/pull/171
> Can you look at this, please?
> Thanks!
> ----
> Regards,
> Nikolay Fedorovskikh.
> _______________________________________________
> slf4j-dev mailing list
> slf4j-dev at qos.ch
> http://mailman.qos.ch/mailman/listinfo/slf4j-dev

More information about the slf4j-dev mailing list