[slf4j-dev] [JIRA] (SLF4J-466) EventRecordingLogger does not properly support the Throwable as last parameter

[QOS.CH (JIRA)]

    [ https://jira.qos.ch/browse/SLF4J-466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=19771#comment-19771 ] 

Wessel van Norel commented on SLF4J-466:
----------------------------------------

I just created a pull request for this issue. By adding the test I also found another bug, one of the warn methods was missing the marker argument. As you can see in the commit: https://github.com/delgurth/slf4j/commit/b99ad9f80f937a91209accd9561332bb9fa30312


The pull request: https://github.com/qos-ch/slf4j/pull/215

> EventRecordingLogger does not properly support the Throwable as last parameter
> ------------------------------------------------------------------------------
>
>                 Key: SLF4J-466
>                 URL: https://jira.qos.ch/browse/SLF4J-466
>             Project: SLF4J
>          Issue Type: Bug
>          Components: Implementations
>    Affects Versions: 1.7.x
>            Reporter: Wessel van Norel
>            Assignee: Ceki Gülcü
>            Priority: Minor
>             Fix For: 2.0.0-alpha1
>
>
> [As per FAQ if the last parameter is a Throwable it should be accepted as the thing you want the stacktrace off.|https://www.slf4j.org/faq.html#paramException]
> In the current EventRecordingLogger implementation, in case you pass two or more objects to the logger the (optional) last Throwable is seen as just an argument and not the actual Throwable.
>  
> This issue also affects 1.8.x and 2.0.x.



--
This message was sent by Atlassian JIRA
(v7.3.1#73012)