Hi Matt,<br><br>OK you are right, hard-coding service ranking is too pragmatic. But how about making SLF4J LogService a OSGi managed service (with updated() method). The developer/user can then set the service ranking via admin console ...<br>
<br>Christian<br><br><div class="gmail_quote">2012/10/23 Matthew Bishop <span dir="ltr"><<a href="mailto:Matthew.Bishop@elasticpath.com" target="_blank">Matthew.Bishop@elasticpath.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="font-size:14px;font-family:Calibri,sans-serif;word-wrap:break-word">
<p></p>
<div>Hi Christian,</div>
<div><br>
</div>
<div>Thank you for the suggestion. We have had a pretty good discussion about the eclipse case and came to the conclusion that it would not be a good idea to change the service ranking but instead to create a specific Eclipse logger that can catch all the various
Eclipse log events (I think there are three total) and log them to SLF4J. It could depend on this specific LogService via the service query. The Eclipse LogService could then provide a higher service level, even with a Property that would be settable in the
Eclipse prefs.</div>
<div><br>
</div>
<div>Osgi-over-slf4j has many places to live other than Eclipse so it needs to play nice across the board. Upping the service ranking in code is definitely not nice.</div>
<div><br>
</div>
<div>Matt</div>
<div><br>
</div>
<div><br>
</div>
<span>
<div style="border-right:medium none;padding-right:0in;padding-left:0in;padding-top:3pt;text-align:left;font-size:11pt;border-bottom:medium none;font-family:Calibri;border-top:#b5c4df 1pt solid;padding-bottom:0in;border-left:medium none">
<span style="font-weight:bold">From: </span>Christian Trutz <<a href="mailto:christian.trutz@belaso.de" target="_blank">christian.trutz@belaso.de</a>><br>
<span style="font-weight:bold">Reply-To: </span>slf4j developers list <<a href="mailto:slf4j-dev@qos.ch" target="_blank">slf4j-dev@qos.ch</a>><br>
<span style="font-weight:bold">Date: </span>Tuesday, 23 October, 2012 11:05 AM<br>
<span style="font-weight:bold">To: </span>"<a href="mailto:slf4j-dev@qos.ch" target="_blank">slf4j-dev@qos.ch</a>" <<a href="mailto:slf4j-dev@qos.ch" target="_blank">slf4j-dev@qos.ch</a>><br>
<span style="font-weight:bold">Subject: </span>[slf4j-dev] discussion about LogService ranking in osgi-over-slf4j<br>
</div><div><div class="h5">
<div><br>
</div>
<div>
<div>Hi osgi-over-slf4j developers,<br>
<br>
I've tested osgi-over-slf4j 1.7.2 with equinox 3.8 and cannot use the SLF4J LogService because<br>
Equinox register also a LogService with default ranking 0. SLF4J gets also ranking 0 (default ranking)<br>
because no service ranking is explicitly set. Is it OK for you if I introduce ranking = 10 for SLF4J LogService?<br>
If want to commit following change:<br>
<br>
Properties props = new Properties();<br>
<b>props.put(Constants.SERVICE_DESCRIPTION, "An SLF4J LogService implementation.");<br>
props.put(Constants.SERVICE_RANKING, 10);</b><br>
ServiceFactory factory = new LogServiceFactory();<br>
bundleContext.registerService(LogService.class.getName(), factory, props);<br>
<br>
to org.slf4j.osgi.logservice.impl.Activator. I also think, that we should made log service ranking configurable ... (via system property for example).<br>
With the above change, I can also see OSGi log messages in Beagle ;-) Thats COOL ...<br>
<br>
Christian<br>
</div>
</div>
</div></div></span>
<p></p>
<table border="0" width="100%">
<tbody>
<tr>
<td width="174"><font face="Calibri"><img src="http://elasticpath.com/images/ep.gif" align="top"></font></td>
<td width="100%"><font><font face="Calibri">
<table>
<tbody>
<tr>
<td><span style="font-family:Calibri;font-size:x-small;font-weight:bold">Matthew Bishop, Senior Architect</span></td>
</tr>
<tr>
<td><span style="font-family:Calibri;font-size:x-small">Phone: 604.408.8078 ext. 101</span></td>
</tr>
<tr>
<td style="text-decoration:none"><span style="font-family:Calibri;font-size:x-small">Email:
<a href="mailto:Matthew.Bishop@elasticpath.com" title="Click to send email to Matthew Bishop" target="_blank">
Matthew.Bishop@elasticpath.com</a></span></td>
</tr>
</tbody>
</table>
</font></font></td>
</tr>
<tr>
<td><font face="Calibri"></font>
</td></tr>
</tbody>
</table>
<font><font face="Calibri"><b>Elastic Path Software, Inc.</b><br>
Web </font></font><a style="TEXT-DECORATION:none" href="http://www.elasticpath.com/" target="_blank"><font face="Calibri">elasticpath.com
</font></a><font face="Calibri">| Blog </font><a style="TEXT-DECORATION:none" href="http://www.getelastic.com/" target="_blank"><font face="Calibri">getelastic.com
</font></a><font face="Calibri">| Twitter </font><a style="TEXT-DECORATION:none" href="http://www.twitter.com/elasticpath" target="_blank"><font face="Calibri">twitter.com/elasticpath
</font></a><br>
<font face="Calibri">Careers </font><a style="TEXT-DECORATION:none" href="http://www.elasticpath.com/jobs" target="_blank"><font face="Calibri">elasticpath.com/jobs</font></a><font face="Calibri"> | Community
</font><a style="TEXT-DECORATION:none" href="http://grep.elasticpath.com/" target="_blank"><font face="Calibri">grep.elasticpath.com
</font></a><br>
<br>
<font color="#736f6e" face="Calibri" size="1">Confidentiality Notice: This message is intended only for the use of the designated addressee(s), and may contain information that is privileged, confidential and exempt from disclosure. Any unauthorized viewing,
disclosure, copying, distribution or use of information contained in this e-mail is prohibited and may be unlawful. If you received this e-mail in error, please reply to the sender immediately to inform us you are not the intended recipient and delete the
email from your computer system. </font>
<p></p>
<p> </p>
</div>
<br>_______________________________________________<br>
slf4j-dev mailing list<br>
<a href="mailto:slf4j-dev@qos.ch">slf4j-dev@qos.ch</a><br>
<a href="http://mailman.qos.ch/mailman/listinfo/slf4j-dev" target="_blank">http://mailman.qos.ch/mailman/listinfo/slf4j-dev</a><br></blockquote></div><br>