Hi Libor,<br><br>I find that implementing the SLF4J LogService as OSGi ManagedService is better than<br><br>- configuring service ranking via system property or<br>- bridging Equinox Log Service implementation to SLF4J<br>
<br>because:<br><br>1) as ManagedService you can change the configuration at runtime and switch between multiple log services. An use case could be: a OSGi application logs regurally with a "default" LogService (not SLF4J LogService) but you want to switsch the log temporally because you want to see the log messages in Beagle for example. With SLF4J as ManagedService you do not have to shutdown and restart you application.<br>
<br>2) bridging Equinox Log Service can be also very confusing for users/admin who don't know that osgi-over-slf4j has this feature ...<br><br>Anyway, I forked slf4j and I'm going to play around with LogService as ManagedService ...<br>
<br>Christian<br><br><br><div class="gmail_quote">2012/10/25 Libor Jelinek <span dir="ltr"><<a href="mailto:ljelinek@virtage.com" target="_blank">ljelinek@virtage.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hello Christian, Hi Matthew,<br>yes we have very very long discussion exactly about it a month or two ago. Matthew is strictly against to these tweak with service ranking. I suggested to introduce a system property that will control this "dominante or not" behaviour which will default to not being dominate (not specifying service ranking) thus keeping backward compatibility with current osgi-over-slf4j. <br>
<br>See my comments <a href="https://github.com/qos-ch/slf4j/pull/24" target="_blank">https://github.com/qos-ch/slf4j/pull/24</a> if you are interested.<br><br>Becoming service manageable via ConfigAdmin is another option. IMHO maybe too much overkill for >>Simple<< Logging Facade 4 Java....<br>
<br>About Eclipse-specific use: Also a month or two ago I suggested this patch <a href="https://github.com/bircow/slf4j/compare/acfb07...a20787" target="_blank">https://github.com/bircow/slf4j/compare/acfb07...a20787</a>. Actually Eclipse doesn't use any specific OSGi Log Service than adding 3-4 methods. So I implemented Equinox ExtendedLogService by inheriting from origin osgi-over-slf4j adding these specific methods.<br>
<br>To cite my previous comments on this topic:<br><i>To idea to fork OOS and maintain autonomous Eclipse bridge: I'm rather<br>against because *there is no actual difference*. Eclipse Platform log is<br>logging to OSGi Log Service (to be specific to Equinox child of LogService<br>
named ExtendedLogService) under the covers. I've reimplemented<br>ExtendedLogService that inherit from current OOS LogService impl, but<br>adding a few of additional methods specific to ExtendedLogService only. You<br>
may review all my proposals at<br><a href="https://github.com/bircow/slf4j/compare/acfb07...a20787" target="_blank">https://github.com/bircow/slf4j/compare/acfb07...a20787</a>. ExtendedLogService<br>impl draft is commit a20787. (Ignore commit specific to ease my OSGi<br>
development in Eclipse PDE tooling.)<br><br>In summary, bridging Eclipse Platform log is are two new files that doesn't<br>have impact to non-Equinox OSGi environments (depedency on Equinox is<br>marked optional).</i><br>
<br>Unfortunatelly due to this difference of opinions among us, these enhancements toward more confortable Eclipse usage still waits. However I'm personally already using it in our own quite large Eclipse-based application with satisfaction. It do what it should do -- real single-target logging, i.e. every log message no matther whether produced by OSGi Log Service or Eclipse Platform Logger is bridged to SLF4J.<br>
<br>--<br>Hezky den / Have a nice day<br>Libor JELÍNEK<br><br>VIRTAGE SOFTWARE // software - design - web<br>Lucni 542 // 285 04 Uhlirske Janovice // Czech Republic<br>support: <a href="tel:%2B420%20315%20555%20488" value="+420315555488" target="_blank">+420 315 555 488</a> // cell: <a href="tel:%2B420%20777%20205%20142" value="+420777205142" target="_blank">+420 777 205 142</a><br>
email/jabber: <a href="mailto:ljelinek@virtage.com" target="_blank">ljelinek@virtage.com</a> // web: <a href="http://www.virtage.com" target="_blank">www.virtage.com</a><br><br>Visit our developer adventures at <a href="http://devblog.virtage.com" target="_blank">http://devblog.virtage.com</a>!<div class="HOEnZb">
<div class="h5"><br>
<br><br>On Tue, Oct 23, 2012 at 8:05 PM, Christian Trutz <<a href="mailto:christian.trutz@belaso.de" target="_blank">christian.trutz@belaso.de</a>> wrote:<br>> Hi osgi-over-slf4j developers,<br>><br>> I've tested osgi-over-slf4j 1.7.2 with equinox 3.8 and cannot use the SLF4J<br>
> LogService because<br>> Equinox register also a LogService with default ranking 0. SLF4J gets also<br>> ranking 0 (default ranking)<br>> because no service ranking is explicitly set. Is it OK for you if I<br>
> introduce ranking = 10 for SLF4J LogService?<br>> If want to commit following change:<br>><br>> Properties props = new Properties();<br>> props.put(Constants.SERVICE_DESCRIPTION, "An SLF4J LogService<br>
> implementation.");<br>> props.put(Constants.SERVICE_RANKING, 10);<br>> ServiceFactory factory = new LogServiceFactory();<br>> bundleContext.registerService(LogService.class.getName(), factory,<br>
> props);<br>><br>> to org.slf4j.osgi.logservice.impl.Activator. I also think, that we should<br>> made log service ranking configurable ... (via system property for example).<br>> With the above change, I can also see OSGi log messages in Beagle ;-) Thats<br>
> COOL ...<br>><br>> Christian<br>><br></div></div><div class="HOEnZb"><div class="h5">> _______________________________________________<br>> slf4j-dev mailing list<br>> <a href="mailto:slf4j-dev@qos.ch" target="_blank">slf4j-dev@qos.ch</a><br>
> <a href="http://mailman.qos.ch/mailman/listinfo/slf4j-dev" target="_blank">http://mailman.qos.ch/mailman/listinfo/slf4j-dev</a><br>
</div></div><br>_______________________________________________<br>
slf4j-dev mailing list<br>
<a href="mailto:slf4j-dev@qos.ch">slf4j-dev@qos.ch</a><br>
<a href="http://mailman.qos.ch/mailman/listinfo/slf4j-dev" target="_blank">http://mailman.qos.ch/mailman/listinfo/slf4j-dev</a><br></blockquote></div><br>