<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div>I'm not a committer, so this isn't a rebuke or anything, just a friendly suggestion. You might get more comments & chance of a merge via a pull request on GitHub - easier for everyone. <br><br><div>Rob</div></div><div><br>On 21 May 2013, at 19:57, "James A. N. Stauffer" <<a href="mailto:stauffer.james@gmail.com">stauffer.james@gmail.com</a>> wrote:<br><br></div><blockquote type="cite"><div><div dir="ltr">Attached fixes/improvements.</div><div class="gmail_extra"><br clear="all"><div><br>James A. N. Stauffer <a href="http://jamesjive.blogspot.com">http://jamesjive.blogspot.com</a><br>Are you good? Take the test at <a href="http://www.livingwaters.com/good/">http://www.livingwaters.com/good/</a></div>
<br><br><div class="gmail_quote">On Tue, May 21, 2013 at 10:57 AM, James A. N. Stauffer <span dir="ltr"><<a href="mailto:stauffer.james@gmail.com" target="_blank">stauffer.james@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">I have attached two patches that add support for <span style="font-family:Verdana,Arial,SunSans-Regular,sans-serif;font-size:13px">parameterized logging. Comments?</span></div><div class="gmail_extra"><div class="im">
<br clear="all">
<div><br>James A. N. Stauffer <a href="http://jamesjive.blogspot.com" target="_blank">http://jamesjive.blogspot.com</a><br>Are you good? Take the test at <a href="http://www.livingwaters.com/good/" target="_blank">http://www.livingwaters.com/good/</a></div>
<br><br></div><div><div class="h5"><div class="gmail_quote">On Tue, May 21, 2013 at 8:17 AM, James A. N. Stauffer <span dir="ltr"><<a href="mailto:stauffer.james@gmail.com" target="_blank">stauffer.james@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><div>(I didn't notice any FAQ/guidelines, etc so please direct me to them if the exist so I can follow protocol.)</div><div><br></div><div>My employer has many projects that use log4j and slf4j is now the approved logging framework. I would like the conversion to make use of the format messages with <span style="font-family:Verdana,Arial,SunSans-Regular,sans-serif">parameterized logging</span> and remove the calls to is*Enabled().</div>
<div><br></div><div>It appears that slf4j-migrator doesn't support that so is there any comment, direction, etc on me adding support for that?</div><div><br></div><div>James A. N. Stauffer <a href="http://jamesjive.blogspot.com" target="_blank">http://jamesjive.blogspot.com</a><br>
Are you good? Take the test at <a href="http://www.livingwaters.com/good/" target="_blank">http://www.livingwaters.com/good/</a></div>
</div>
</blockquote></div><br></div></div></div>
</blockquote></div><br></div>
</div></blockquote><blockquote type="cite"><div><0003-Fixed-minor-bugs-with-format-conversion.patch></div></blockquote><blockquote type="cite"><div><span>_______________________________________________</span><br><span>slf4j-dev mailing list</span><br><span><a href="mailto:slf4j-dev@qos.ch">slf4j-dev@qos.ch</a></span><br><span><a href="http://mailman.qos.ch/mailman/listinfo/slf4j-dev">http://mailman.qos.ch/mailman/listinfo/slf4j-dev</a></span></div></blockquote></body></html>