[cal10n-dev] Some suggestions based on a code review

[Rick Beton]

Hi Ceki,

I have been reading through the Cal10n code, which I cloned from Git so as
to get the most up to date.  I'd like to offer a patch file containing some
suggested changes - see attached.

* some javadoc alterations

* more fields are private

* some fields are final to distinguish them from 'accumulator' variables
(this shows my functional programming tendencies!)

* CAL10NResourceBundle hasChanged method now computes the periodicity
correctly

* CAL10NResourceBundle has new getMap() method to remove the assumption that
there is only one parent level.

I may be able to put together a first effort at integrating Cal10n with Ant;
it depends on how busy I am this week and whether my colleagues want to try
out Cal10n further.  (I've done bits of Ant before - the javah task is my
work).

Regards,
Rick
-- 
Big Bee Consultants Limited : Registered in England & Wales No. 6397941
Registered Office: 71 The Hundred, Romsey, Hampshire, SO51 8BZ
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://qos.ch/pipermail/cal10n-dev/attachments/20100314/35521a85/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rick.patch
Type: text/x-patch
Size: 8264 bytes
Desc: not available
URL: <http://qos.ch/pipermail/cal10n-dev/attachments/20100314/35521a85/attachment.bin>