[logback-dev] svn commit: r959 - in logback/trunk/logback-core/src/test/java/ch/qos/logback/core: joran/event joran/ia joran/replay joran/spi pattern/parser

noreply.ceki at qos.ch noreply.ceki at qos.ch
Sun Nov 19 16:33:14 CET 2006


Author: ceki
Date: Sun Nov 19 16:33:14 2006
New Revision: 959

Modified:
   logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/event/InPlayFireTest.java
   logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/ia/SimplePropertyIATest.java
   logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/replay/Fruit.java
   logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/replay/FruitFactory.java
   logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/spi/SimpleStoreTest.java
   logback/trunk/logback-core/src/test/java/ch/qos/logback/core/pattern/parser/SamplePatternLayoutTest.java

Log:
silent tests are beautiful

Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/event/InPlayFireTest.java
==============================================================================
--- logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/event/InPlayFireTest.java	(original)
+++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/event/InPlayFireTest.java	Sun Nov 19 16:33:14 2006
@@ -34,9 +34,9 @@
     gc.setContext(context);
     gc.doConfigure(Constants.TEST_DIR_PREFIX + "input/joran/fire1.xml");
     
-    for(SaxEvent se: listenAction.getSeList()) {
-      System.out.println(se);
-    }
+    //for(SaxEvent se: listenAction.getSeList()) {
+    //  System.out.println(se);
+    //}
     assertEquals(5, listenAction.getSeList().size());
     assertTrue(listenAction.getSeList().get(0) instanceof StartEvent);
     assertTrue(listenAction.getSeList().get(1) instanceof StartEvent);
@@ -53,9 +53,9 @@
     gc.setContext(context);
     gc.doConfigure(Constants.TEST_DIR_PREFIX + "input/joran/fire1.xml");
     
-    for(SaxEvent se: listenAction.getSeList()) {
-      System.out.println(se);
-    }
+//    for(SaxEvent se: listenAction.getSeList()) {
+//      System.out.println(se);
+//    }
     assertEquals(5, listenAction.getSeList().size());
     assertTrue(listenAction.getSeList().get(0) instanceof StartEvent);
     assertTrue(listenAction.getSeList().get(1) instanceof StartEvent);

Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/ia/SimplePropertyIATest.java
==============================================================================
--- logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/ia/SimplePropertyIATest.java	(original)
+++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/ia/SimplePropertyIATest.java	Sun Nov 19 16:33:14 2006
@@ -37,7 +37,6 @@
 
       simpleConfigurator.doConfigure(Constants.TEST_DIR_PREFIX + "input/joran/"
           + "simplePropertyIA1.xml");
-      StatusPrinter.print(fruitContext);
       List<Fruit> fList = fruitContext.getFruitList();
       assertNotNull(fList);
       assertEquals(1, fList.size());

Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/replay/Fruit.java
==============================================================================
--- logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/replay/Fruit.java	(original)
+++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/replay/Fruit.java	Sun Nov 19 16:33:14 2006
@@ -9,7 +9,7 @@
   List<String> textList = new ArrayList<String>();
   
   public Fruit() {
-    System.out.println("Fruit constructor called");
+    // System.out.println("Fruit constructor called");
   }
 
   public void setName(String name) {

Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/replay/FruitFactory.java
==============================================================================
--- logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/replay/FruitFactory.java	(original)
+++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/replay/FruitFactory.java	Sun Nov 19 16:33:14 2006
@@ -19,9 +19,7 @@
   }
 
   public Fruit buildFruit() {
-    for (SaxEvent se : eventList) {
-      System.out.println("Event to replay: "+se);
-    }
+    
     Context context = new ContextBase();
     this.fruit = null;
     context.setProperty("fruitKey", "orange-"+count);

Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/spi/SimpleStoreTest.java
==============================================================================
--- logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/spi/SimpleStoreTest.java	(original)
+++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/spi/SimpleStoreTest.java	Sun Nov 19 16:33:14 2006
@@ -192,7 +192,6 @@
     srs.addRule(new Pattern("testGroup/testShell/test/*"), new XAction(9));
     
     List r = srs.matchActions(new Pattern("testGroup/testShell/toto"));
-    System.out.println(r);
     assertNull(r);
   }
   

Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/pattern/parser/SamplePatternLayoutTest.java
==============================================================================
--- logback/trunk/logback-core/src/test/java/ch/qos/logback/core/pattern/parser/SamplePatternLayoutTest.java	(original)
+++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/pattern/parser/SamplePatternLayoutTest.java	Sun Nov 19 16:33:14 2006
@@ -12,8 +12,6 @@
 import ch.qos.logback.core.Context;
 import ch.qos.logback.core.ContextBase;
 import ch.qos.logback.core.pattern.PatternLayoutBase;
-import ch.qos.logback.core.status.StatusManager;
-import ch.qos.logback.core.util.StatusPrinter;
 
 
 public class SamplePatternLayoutTest extends AbstractPatternLayoutBaseTest {



More information about the logback-dev mailing list