[logback-dev] [Bug 104] Copy/Paste errors in Logger. TurboFilter probably not working correctly.

bugzilla-daemon at pixie.qos.ch bugzilla-daemon at pixie.qos.ch
Wed Jan 23 16:32:41 CET 2008


http://bugzilla.qos.ch/show_bug.cgi?id=104





------- Comment #3 from joern at huxhorn.de  2008-01-23 16:32 -------
Looks fine.

I just think that the "if (isDebugEnabled())" in line 414 isn't necessary if a
"if (isTraceEnabled())" isn't necessary in line 390.

I thought that this was probably a performance optimization since debug and
trace is called more often than info, warn and error... I wasn't sure so I just
changed it to isTrace instead of isDebug.

Am I supposed to close this bug? I don't have a testcase but reviewed the
changes. 


-- 
Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the logback-dev mailing list