[logback-dev] svn commit: r1932 - logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/spi

[Ceki Gulcu]

By not working on Linux, I meant that LoggingEventSerializationPerfTest does not 
pass on Linux, either due to JIT issues or due to 64 bit to 32 cast issues. In 
any case, we should not jeopardize the build on the cont. integration system.

Performance tests are similar too walking on thin ice. You've got to punt on 
occasion.



Ceki Gulcu wrote:
> Hi Ralph,
> 
> It's a new test verifying LoggingEvent serialization. It does not work on Linux, 
> either because we run it on a AMD 64bit machine with a 64 bit JVM, requiring 
> 32bit casts, or some other reason such as JIT differences. I think it is 
> probably the latter.
> 
> Ralph Goers wrote:
>> ????
>>
>> noreply.ceki at qos.ch wrote:
>>> Author: ceki
>>> Date: Sat Nov  1 18:22:56 2008
>>> New Revision: 1932
>>>
>>> Modified:
>>>    logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/spi/LoggingEventSerializationPerfTest.java
>>>
>>> Log:
>>> this test does not run on Linux
>>>
>>> Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/spi/LoggingEventSerializationPerfTest.java
>>> ==============================================================================
>>> --- logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/spi/LoggingEventSerializationPerfTest.java	(original)
>>> +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/spi/LoggingEventSerializationPerfTest.java	Sat Nov  1 18:22:56 2008
>>> @@ -16,6 +16,7 @@
>>>  import ch.qos.logback.classic.net.testObjectBuilders.LoggingEventWithParametersBuilder;
>>>  import ch.qos.logback.classic.net.testObjectBuilders.TrivialLoggingEventBuilder;
>>>  import ch.qos.logback.core.CoreConstants;
>>> +import ch.qos.logback.core.testUtil.Env;
>>>  
>>>  public class LoggingEventSerializationPerfTest {
>>>  
>>> @@ -56,6 +57,9 @@
>>>  
>>>    @Test
>>>    public void testPerformance() {
>>> +    if (Env.isLinux()) {
>>> +      return;
>>> +    }
>>>      TrivialLoggingEventBuilder builder = new TrivialLoggingEventBuilder();
>>>  
>>>      doLoop(builder, LOOP_LEN);
>>> _______________________________________________
>>> logback-dev mailing list
>>> logback-dev at qos.ch
>>> http://qos.ch/mailman/listinfo/logback-dev
>>>   
>> _______________________________________________
>> logback-dev mailing list
>> logback-dev at qos.ch
>> http://qos.ch/mailman/listinfo/logback-dev
> 

-- 
Ceki Gülcü
Logback: The reliable, generic, fast and flexible logging framework for Java.
http://logback.qos.ch