[logback-dev] [JIRA] Commented: (LBCLASSIC-46) ThrowableInformation should keep the Throwable cause hierarchy intact.
Joern Huxhorn (JIRA)
noreply-jira at qos.ch
Sat Nov 8 09:35:21 CET 2008
[ http://jira.qos.ch/browse/LBCLASSIC-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=10890#action_10890 ]
Joern Huxhorn commented on LBCLASSIC-46:
----------------------------------------
Ceki,
I don't mean to bug you but do you think that it would be possible to find a solution before a 0.9.12 release?
At the moment, Lilith still requires the use of logback-0.9.9 because I don't want/have the time to implement the parsing of the Throwable... on the other hand, I'd really like to have a new release ready soon after 0.9.12 has been released.
Unfortunately, I wasn't able to call you last week. I'm pretty occupied at the moment...
> ThrowableInformation should keep the Throwable cause hierarchy intact.
> ----------------------------------------------------------------------
>
> Key: LBCLASSIC-46
> URL: http://jira.qos.ch/browse/LBCLASSIC-46
> Project: logback-classic
> Issue Type: Improvement
> Components: Other
> Affects Versions: unspecified
> Environment: Operating System: All
> Platform: All
> Reporter: Joern Huxhorn
> Assignee: Ceki Gulcu
> Priority: Minor
>
> Instead of a String representation of the whole Throwable stack trace incl. cause ThrowableInformation should instead look like this:
> public class ThrowableInformation implements Serializable
> {
> String throwableClassName;
> String message;
> StackTraceElement[] stackTrace;
> ThrowableInformation cause;
> }
> I omitted get/set and private in this example.
> StackTraceElement is perfectly Serializable and did also receive a public c'tor in Java 5 so I guess that the current ThrowableInformation is more or less a relict of log4j which had to stay compatible with older Java versions.
> You could obviously keep the getThrowableStrRep() method for compatibility.
> This bug is somewhat related to LBCLASSIC-45 because I think that ThrowableInformation should also, as LoggingEvent, be just a dumb data container with no real logic.
> The logic to extract the relevant StackTraceElements should IMHO be moved either into Logger or into a static factory method of ThrowableInformation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
More information about the logback-dev
mailing list