[logback-dev] [JIRA] Resolved: (LBCORE-55) getPresentationFooter and getFileFooter are swapped

[Ceki Gulcu (JIRA)]

     [ http://jira.qos.ch/browse/LBCORE-55?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ceki Gulcu resolved LBCORE-55.
------------------------------

    Fix Version/s: 0.9.10
       Resolution: Fixed


Natan,

Thank you for reporting bug. It was fixed in revision 1842.


> getPresentationFooter and getFileFooter are swapped
> ---------------------------------------------------
>
>                 Key: LBCORE-55
>                 URL: http://jira.qos.ch/browse/LBCORE-55
>             Project: logback-core
>          Issue Type: Bug
>          Components: Appender
>            Reporter: Natan Cox
>            Assignee: Logback dev list
>             Fix For: 0.9.10
>
>
> If I look into the code I can see in WriterAppender writeFooter
>      String h = layout.getFileFooter();
>      if ((h != null) && (this.writer != null)) {
>        try {
>          this.writer.write(h);
>          String pf = layout.getPresentationFooter();
>          if (pf != null) {
>            this.writer.write(pf);
>          }
> And if I look into HTMLLayoutBase I see
>  getFileFooter =>     </body></html>
>  getPresentationFooter => </table>
> which means we are first closing the HTML and then the TABLE?
> Fix:
>      String pf = layout.getPresentationFooter();
>      if ((pf != null) && (this.writer != null)) {
>        try {
>          this.writer.write(pf);
>          String h = layout.getFileFooter();
>          if (h != null) {
>            this.writer.write(h);
>          }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira