[logback-dev] [JIRA] Issue Comment Edited: (LBCORE-52) Make SyslogAppenderBase fields protected

[Ceki Gulcu (JIRA)]

    [ http://jira.qos.ch/browse/LBCORE-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=10786#action_10786 ] 

Ceki Gulcu edited comment on LBCORE-52 at 10/18/08 9:35 PM:
------------------------------------------------------------

The facilityStr, syslogHost, port, and suffixPattern fields in SyslogAppenderBase have public setters. 
The prefixPattern variable is internal to the buildLayout class. 

Given the above, I don't think it makes sense to assent to your request, except in relation to the 'prefixLayout' variable, although that is not clear either. 

Please re-open this bug if you need access to the   'prefixLayout' variable.


      was (Author: noreply.ceki at qos.ch):
    
The facilityStr, syslogHost, port, and suffixPattern fields in SyslogAppenderBase have public setters. 

The prefixPattern and prefixLayout layout are internal to the buildLayout class.

Give the above, I don't think it makes sense to assent to your request.
  
> Make SyslogAppenderBase fields protected
> ----------------------------------------
>
>                 Key: LBCORE-52
>                 URL: http://jira.qos.ch/browse/LBCORE-52
>             Project: logback-core
>          Issue Type: Improvement
>            Reporter: Anton Tagunov
>            Assignee: Logback dev list
>             Fix For: 0.9.10
>
>         Attachments: protected.diff
>
>
> Hi! We'd like to customize some of SyslogAppender. Since SyslogAppenderBase class is public and is a base class by destination
> would it be appropriate to have all of the fields be designated as 'protected'?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira