[logback-dev] [JIRA] Commented: (LBCORE-67) Unsecure usage of locks in AppenderAttachableImpl

Ralph Goers (JIRA) noreply-jira at qos.ch
Tue Oct 28 15:03:21 CET 2008

    [ http://jira.qos.ch/browse/LBCORE-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=10817#action_10817 ] 

Ralph Goers commented on LBCORE-67:

In this case I have to agree with Joern. A test case shouldn't be necessary. All the code being locked must always be in the try block with the unlock in the finally. It is too bad the compiler can' generate an error when it isn't done that way. 

> Unsecure usage of locks in AppenderAttachableImpl
> -------------------------------------------------
>                 Key: LBCORE-67
>                 URL: http://jira.qos.ch/browse/LBCORE-67
>             Project: logback-core
>          Issue Type: Bug
>          Components: Appender
>    Affects Versions: 0.9.10
>            Reporter: Joern Huxhorn
>            Assignee: Logback dev list
>         Attachments: LockPatch.patch
> The unlock of a lock should, I would even say "must", always be done in
> a finally block. Otherwise really bad things (deadlock) can happen if an exception
> is thrown.
> See http://java.sun.com/j2se/1.5.0/docs/api/java/util/concurrent/locks/Lock.html

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


More information about the logback-dev mailing list