[logback-dev] [JIRA] Commented: (LBCORE-1) Appender interface managing Layouts?

[Joern Huxhorn (JIRA)]

    [ http://jira.qos.ch/browse/LBCORE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=10830#action_10830 ] 

Joern Huxhorn commented on LBCORE-1:
------------------------------------

This isn't exactly a duplicate of LBCORE-56 as that report is about AppenderBase, not the Appender interface itself.

The Appender should probably only be concerned about basic appender functionality, i.e. doAppend and get/setName(). Those are both absolutely required by every Appender.

set/getLayout, as well as the methods contained in LifeCycle, ContextAware and FilterAttachable, are not really necessary in every type of appender so I'd even suggest to remove the whole 'extends' section from the interface.

I fully understand that this would mean a severe refactoring but it would ultimately result in cleaner Appender implementations that would only implement the supported part of the API.

That's just an idea and nothing absolutely necessary so just ignore it if you don't like it :)

> Appender interface managing Layouts?
> ------------------------------------
>
>                 Key: LBCORE-1
>                 URL: http://jira.qos.ch/browse/LBCORE-1
>             Project: logback-core
>          Issue Type: Bug
>          Components: Appender
>    Affects Versions: unspecified
>         Environment: Operating System: All
> Platform: All
>            Reporter: Sébastien Pennec
>            Assignee: Logback dev list
>             Fix For: unspecified
>
>
> Why does the c.p.l.core.Appender interface includes a getter and a setter for Layout?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira