[logback-dev] [JIRA] Commented: (LBCLASSIC-145) SocketAppender is omitting CallerData.

[Joern Huxhorn (JIRA)]

    [ http://jira.qos.ch/browse/LBCLASSIC-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11263#action_11263 ] 

Joern Huxhorn commented on LBCLASSIC-145:
-----------------------------------------

I can confirm that everything is now working correctly.

Thanks a lot for the quick fix!

> SocketAppender is omitting CallerData.
> --------------------------------------
>
>                 Key: LBCLASSIC-145
>                 URL: http://jira.qos.ch/browse/LBCLASSIC-145
>             Project: logback-classic
>          Issue Type: Bug
>          Components: appender
>    Affects Versions: 0.9.16
>            Reporter: Joern Huxhorn
>            Assignee: Ceki Gulcu
>             Fix For: 0.917
>
>
> LoggingEventVO is never assigning a value to callerDataArray so the caller data is omitted regardless of the value of SocketAppenders includeCallerData property.
> As far as I can tell, this should probably be implemented in 
> LoggingEventVO build(ILoggingEvent le)
> like this:
> if(le.hasCallerData()) {
>   ledo.callerData = le.getCallerData();
> }
> I'm unsure where the caller data should be obtained, though.
> LoggingEventPreSerializationTransformer will probably need an includeCallerData property that's initialized whenever the setIncludeCallerData of SocketAppender is called. It could then execute getCallerData(), if requested, before calling build.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira