[logback-dev] [JIRA] Commented: (LBCLASSIC-147) TwitterAppender

[Ceki Gulcu (JIRA)]

    [ http://jira.qos.ch/browse/LBCLASSIC-147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11269#action_11269 ] 

Ceki Gulcu commented on LBCLASSIC-147:
--------------------------------------

Hi Joern,

Thank you for contributing TwitterAppender. I've looked at it briefly and noticed that you are using the setter convention instead of the adder convention [1] for managing a collection of properties. Using the adder convention is idiomatic in logback. For example, SMTPAppender uses it for the destination email addresses. Otherwise, it looks good. :-)

[1] http://logback.qos.ch/manual/onJoran.html#iaPractice


> TwitterAppender
> ---------------
>
>                 Key: LBCLASSIC-147
>                 URL: http://jira.qos.ch/browse/LBCLASSIC-147
>             Project: logback-classic
>          Issue Type: New Feature
>          Components: appender
>    Affects Versions: 0.917
>            Reporter: Joern Huxhorn
>            Assignee: Logback dev list
>         Attachments: twitter-appender.zip
>
>
> I've implemented a prototype of a TwitterAppender, as discussed on the mailinglist.
> http://www.nabble.com/Twitter-Appender--to24792908.html#a24792908
> Please forget my message about the encoding problem, it was entirely my fault.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira