[logback-dev] [JIRA] Commented: (LBCLASSIC-102) Suggestion: Change logger name of inner classes.

Joern Huxhorn (JIRA) noreply-jira at qos.ch
Mon Dec 14 16:45:33 CET 2009


    [ http://jira.qos.ch/browse/LBCLASSIC-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11447#action_11447 ] 

Joern Huxhorn commented on LBCLASSIC-102:
-----------------------------------------

Sorry, I just filed LBCLASSIC-172 because of this.

This is IMHO a bug since nothing prevents me from using SLF4J that way. And I see no reason why WeakHashMap would be a problem, if I look at LoggerContext source.

Keep in mind that weak entries are only removed if a garbage-collection is performed. They *are* cached until GC. So even the relatively costly creation isn't a very valid argument.

> Suggestion: Change logger name of inner classes.
> ------------------------------------------------
>
>                 Key: LBCLASSIC-102
>                 URL: http://jira.qos.ch/browse/LBCLASSIC-102
>             Project: logback-classic
>          Issue Type: Improvement
>          Components: appender
>    Affects Versions: 0.9.15
>            Reporter: Joern Huxhorn
>            Assignee: Ceki Gulcu
>             Fix For: 0.9.18
>
>
> At the moment, the logger name of inner classes is OuterClass$InnerClass.
> Because of that, the logging level of OuterClass isn't inherited by InnerClass at the moment.
> If LoggerFactory changed the logger name to OuterClass.InnerClass instead, InnerClass would inherit the logging level of OuterClass which seems intuitively correct.
> I'd suggest to accept both $InnerClass and .InnerClass style in logback configurations for compatibility and usability reasons.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        


More information about the logback-dev mailing list