[logback-dev] [JIRA] Commented: (LBCLASSIC-22) feature request: XMLLayout (cfr. log4j)

Thorbjoern Ravn Andersen (JIRA) noreply-jira at qos.ch
Thu Feb 5 23:58:47 CET 2009


    [ http://jira.qos.ch/browse/LBCLASSIC-22?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11035#action_11035 ] 

Thorbjoern Ravn Andersen commented on LBCLASSIC-22:
---------------------------------------------------

I do not understand the "as found in our repository" sentence.  You added the file yesteday after I uploaded a revised patch, so the file was not there  (unless I missed something).

The time field was added to  make the XML output readable to a human looking at the file, as nobody I know can understand timestamps in his head.  This also includes the careful formatting of the output with line breaks.

My character transformation is a clean design working well without the disambiguity of the CDATA (is a <tag> a real tag or a part of a CDATA stream) and as an added benefit generates 7-bit clean output.

I have produced a neat implementation conforming to logback conventions and tested it with Chainsaw.  You haven't even made a single comment on this issue even though its been in here for 14 months, decided to disregard my work and just grab the log4j implementation, add the MDC lines and calling it FIXED.   

I would have appreciated discussing this on logback-dev before the fact and not in comments after the fact.  

As it is now I see no reason my name is in the @authors tag in the file, and I would appreciate it if you removed it.

> feature request: XMLLayout (cfr. log4j)
> ---------------------------------------
>
>                 Key: LBCLASSIC-22
>                 URL: http://jira.qos.ch/browse/LBCLASSIC-22
>             Project: logback-classic
>          Issue Type: Improvement
>          Components: Other
>    Affects Versions: unspecified
>         Environment: Operating System: Linux
> Platform: PC
>            Reporter: dirk
>            Assignee: Ceki Gulcu
>            Priority: Minor
>             Fix For: 0.9.15
>
>         Attachments: XMLLayout.jar, XMLLayout.java
>
>
> see Summary

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        


More information about the logback-dev mailing list