[logback-dev] [JIRA] Commented: (LBCLASSIC-36) Synchronization of SimpleDateFormat object in DateConverter

[Ralph Goers (JIRA)]

    [ http://jira.qos.ch/browse/LBCLASSIC-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11189#action_11189 ] 

Ralph Goers commented on LBCLASSIC-36:
--------------------------------------

My results on my Macbook Pro. The difference is a little bit more significant, possibly since it is obviously a much faster machine. If this holds true then in production this would be even more significant. Unfortunately, I don't have a quad or 8-way processor to test this.

=== DateFormatting ===
java.runtime.version = 1.5.0_16-b06-284
java.vendor          = Apple Inc.
java.version         = 1.5.0_16
os.name              = Mac OS X
os.version           = 10.5.7
JODA: total of 13410524 operations, or 4470 operations per millisecond
SDF:  total of 10319665 operations, or 3439 operations per millisecond


> Synchronization of SimpleDateFormat object in DateConverter
> -----------------------------------------------------------
>
>                 Key: LBCLASSIC-36
>                 URL: http://jira.qos.ch/browse/LBCLASSIC-36
>             Project: logback-classic
>          Issue Type: Bug
>          Components: Other
>    Affects Versions: unspecified
>         Environment: Operating System: All
> Platform: All
>            Reporter: Anders Hammar
>            Assignee: Ceki Gulcu
>         Attachments: DateConverter_patch.java, DateFormatPerfTest.java, dateformattest.zip
>
>
> According to the API documentation of SimpleDateFormat, date formats are not synchronized and it is recommended to create separate format instances for each thread.
> However, a possibly simpler (mer efficient) solution would be to synchronize on the SimpleDateFormat object in the convert() method to prevent two threads to access it concurrently.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira