[logback-dev] [JIRA] Issue Comment Edited: (LBCORE-128) Please support implementation of binary log files in RollingFileAppender/FileAppender

[Ceki Gulcu (JIRA)]

    [ http://jira.qos.ch/browse/LBCORE-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11531#action_11531 ] 

Ceki Gulcu edited comment on LBCORE-128 at 2/16/10 10:43 PM:
-------------------------------------------------------------

While fixing LBCORE-109, I'll try to fix this bug as well. When this issue was raised previously, I remember being impressed by  Maarten Bosteel's ideas as well:

  http://tinyurl.com/encoder-interface  
  http://tinyurl.com/encoder-example

I'll try to address both issues if I can. 

Here are several use cases one can imagine: 

1) write a text stream using a layout
2) write a compressed stream using a layout
3) write logging events as Objects, no layout necessary
4) write logging objects encoded with ProtoBuf, no layout necessary.

Looking your  LBCORE-128 branch and in particular at http://github.com/huxi/logback/commit/d1d9a045ec55a856560909151a1f51fee3851f5d, I am guessing that your are catering for cases 1 and 2 described above but I don't see how you instruct FileAppender to use a compressed stream. Am I missing a commit, or have you put the general design in place leaving some details unimplemented?

      was (Author: noreply.ceki at qos.ch):
    While fixing LBCORE-109, I'll try to fix this bug as well. When this issue was raised previously, I remember being impressed by  Maarten Bosteel's ideas as well:

  http://tinyurl.com/encoder-interface  
  http://tinyurl.com/encoder-example

I'll try to address both issues if I can. There are 

1) write a text stream using a layout
2) write a compressed stream using a layout
3) write logging events as Objects, no layout is necessary
4) write logging objects encoded with ProtoBuf, no layout is neccesssary.

Looking your  LBCORE-128 branch and in particular at http://github.com/huxi/logback/commit/d1d9a045ec55a856560909151a1f51fee3851f5d, I am guessing that your are catering for cases 1 and 2 described above but I don't see how you instruct FileAppender to use a compressed stream. Am I missing a commit, or have you put the general design in place leaving some details unimplemented?
  
> Please support implementation of binary log files in RollingFileAppender/FileAppender
> -------------------------------------------------------------------------------------
>
>                 Key: LBCORE-128
>                 URL: http://jira.qos.ch/browse/LBCORE-128
>             Project: logback-core
>          Issue Type: Improvement
>          Components: Appender
>    Affects Versions: 0.9.17
>            Reporter: Joern Huxhorn
>            Assignee: Ceki Gulcu
>
> This was discussed briefly at http://marc.info/?l=logback-dev&m=124905434331308&w=2 and I forgot to file a ticket about this.
> Currently, RandomFileAppender => FileAppender => WriterAppender is using the following method in WriterAppender to actually write the data:
> protected void writerWrite(String s, boolean flush) throws IOException
> Please add an additional method like
> protected void writerWrite(byte[] bytes, boolean flush) throws IOException
> to write to the underlying stream directly.
> writerWrite(String, boolean) could call that method after performing the transformation internally, making this change transparent for the rest of the implementation.
> Using a binary format for logfiles could have tremendous performance impact as can be seen here: http://sourceforge.net/apps/trac/lilith/wiki/SerializationPerformance

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira