[logback-dev] [JIRA] Commented: (LBCORE-128) Please support implementation of binary log files in RollingFileAppender/FileAppender

[Joern Huxhorn (JIRA)]

    [ http://jira.qos.ch/browse/LBCORE-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11583#action_11583 ] 

Joern Huxhorn commented on LBCORE-128:
--------------------------------------

One more thing I forgot to mention:

While developing, I've seen the following output:
10:48:46,039 |-INFO in ch.qos.logback.core.joran.action.AppenderAction - Naming appender as [CONSOLE]
10:48:46,043 |-ERROR in ch.qos.logback.core.joran.spi.Interpreter at 23:56 - no applicable action for [layout], current pattern is [[configuration][appender][layout]]
10:48:46,044 |-WARN in ch.qos.logback.core.joran.util.PropertySetter at 693985fc - No such property [pattern] in ch.qos.logback.core.ConsoleAppender.
10:48:46,044 |-WARN in ch.qos.logback.core.ConsoleAppender[CONSOLE] - Encoder not yet set. Cannot invoke it's init method
10:48:46,044 |-ERROR in ch.qos.logback.core.ConsoleAppender[CONSOLE] - No encoder set for the appender named "CONSOLE".
10:48:46,044 |-INFO in ch.qos.logback.core.joran.action.AppenderAction - Popping appender named [CONSOLE] from the object stack

It would be nice if
<appender name="CONSOLE" class="ch.qos.logback.core.ConsoleAppender">
	<layout class="ch.qos.logback.classic.PatternLayout">
		<param name="Pattern" value="%date %level [%thread] %logger{10} [%file:%line] %msg%n" />
	</layout>
</appender>

would result in the same behavior as

<appender name="CONSOLE" class="ch.qos.logback.core.ConsoleAppender">
	<encoder>
		<pattern>%date %level [%thread] %logger{10} [%file:%line] %msg%n</pattern>
	</encoder>
</appender>

Just for backwards compatibility. Otherwise, people might get irritated.

Cheers,
Joern.

> Please support implementation of binary log files in RollingFileAppender/FileAppender
> -------------------------------------------------------------------------------------
>
>                 Key: LBCORE-128
>                 URL: http://jira.qos.ch/browse/LBCORE-128
>             Project: logback-core
>          Issue Type: Improvement
>          Components: Appender
>    Affects Versions: 0.9.17
>            Reporter: Joern Huxhorn
>            Assignee: Ceki Gulcu
>
> This was discussed briefly at http://marc.info/?l=logback-dev&m=124905434331308&w=2 and I forgot to file a ticket about this.
> Currently, RandomFileAppender => FileAppender => WriterAppender is using the following method in WriterAppender to actually write the data:
> protected void writerWrite(String s, boolean flush) throws IOException
> Please add an additional method like
> protected void writerWrite(byte[] bytes, boolean flush) throws IOException
> to write to the underlying stream directly.
> writerWrite(String, boolean) could call that method after performing the transformation internally, making this change transparent for the rest of the implementation.
> Using a binary format for logfiles could have tremendous performance impact as can be seen here: http://sourceforge.net/apps/trac/lilith/wiki/SerializationPerformance

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira