[logback-dev] [JIRA] Issue Comment Edited: (LBCLASSIC-184) Remove Cyclic Dependencies between Classic, SLF4J API and SLF4J Impl

[Ceki Gulcu (JIRA)]

    [ http://jira.qos.ch/browse/LBCLASSIC-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11631#action_11631 ] 

Ceki Gulcu edited comment on LBCLASSIC-184 at 3/18/10 2:30 PM:
---------------------------------------------------------------

Recent commit [1] removes references to org.slf4j.impl package from ch.qos.logback.classic
Unfortunately, the osgi-test cases no longer pass. I'll attach the test output shortly. The fact the tests don't pass means that the current bundles slf4j-api.jar, logback-classic.jar,  logback-core.jar cannot be loaded by OSGi even if with your bundling structure which has the extra logback-SLF4J-Impl bundle declaring slf4j-api as a fragment-host things might work differently/better. 

Anyway, it would be nice if you could try out if my commit works for you. Any suggestions for having the osgi tests pass would be welcome. 

[1] http://github.com/ceki/logback/commit/4fa9166747fc


      was (Author: noreply.ceki at qos.ch):
    Recent commit [1] removes references to org.slf4j.impl package from ch.qos.logback.classic
Unfortunately, the osgi-test cases no longer pass. I'll attach the test output shortly. The fact the tests don't pass means that the current bundles slf4j-api.jar, logback-classic.jar,  logback-core.jar cannot be loaded by OSGi even if with yYour bundling strucutre which has the extra logback-SLF4J-Impl bundle declaring slf4j-api as a fragment-host things might work differently/better. 

Anyway, it would be nice if you could try out if my commit works for you. Any suggestions for having the osgi-test would be welcome. 

[1] http://github.com/ceki/logback/commit/4fa9166747fc

  
> Remove Cyclic Dependencies between Classic, SLF4J API and SLF4J Impl
> --------------------------------------------------------------------
>
>                 Key: LBCLASSIC-184
>                 URL: http://jira.qos.ch/browse/LBCLASSIC-184
>             Project: logback-classic
>          Issue Type: Task
>          Components: Other
>    Affects Versions: 0.9.18
>            Reporter: Gunnar Wagenknecht
>            Assignee: Ceki Gulcu
>            Priority: Critical
>         Attachments: context-selector.patch, mdc-move.patch, TEST-org.slf4j.test_osgi.BundleTest.txt
>
>
> When working with Logback as OSGi bundles I found some issues regarding cyclic dependencies. Basically, code in "org.slf4j.impl" depends on "org.slf4j.api" as well as Logback classic. This is fine. However, code in Logback classic also depends on "org.slf4j.impl". This introduces a cycle.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira