[logback-dev] Throwable.getSuppressed()

[Joern Huxhorn]

Hi Ceki,
thanks a lot!
I just merged my pull request.

Now we'd need to decide how support should be added to
• ch.qos.logback.classic.db.DBAppender
• ch.qos.logback.classic.html.DefaultThrowableRenderer
• ch.qos.logback.classic.net.SyslogAppender
• ch.qos.logback.classic.pattern.ThrowableProxyConverter
• ch.qos.logback.classic.spi.ThrowableProxyUtil.asString

I've taken a look at the LBCLASSIC-296 code (both https://github.com/chrisdolan/logback/commit/eb1b03ac72f0534d9152279e39d85a81615a5e78 and https://github.com/chrisdolan/logback/commit/01c4b17766e59eee613d2777963f536015908d6b ) and it looks quite reasonable to me.

Unfortunately, OSGi isn't something I have a lot of experience with - so I can only say "Yes, looks reasonable".
I'd suggest that Chris pulls in my changes and creates a branch with his changes so we can just pull them in.

I'm not sure about <scope>provided</scope> in logback-classic/pom.xml, though. I think it should be <scope>compile</scope><optional>true</optional> instead.

Cheers,
Joern.

On 04.11.2011, at 08:57, ceki wrote:

> Hi Joern,
> 
> I just added you as a project participant on
> https://github.com/ceki/logback/. You should be able to apply the
> patch yourself.
> 
> It'd be cool if you can also have a look at LBCLASSIC-296 and the
> patch submitted by Chris Dolan? It's a tough assignment, so please
> feel free to decline.
> 
> -- 
> Ceki
> http://twitter.com/#!/ceki
> 
> On 03/11/2011 8:56 PM, ceki wrote:
>> Hi Joern,
>> 
>> It's on my todo list.
>> 
>> On 03/11/2011 4:09 PM, Joern Huxhorn wrote:
>>> Any chance of getting http://jira.qos.ch/browse/LBCLASSIC-276 /
>>> https://github.com/ceki/logback/pull/16 pulled in the near future?
>>> 
>>> Otherwise I'd do another Lilith release without fully supporting
>>> Throwable.getSuppressed().
>>> 
>>> Joern.
>> 
>> 
> 
> _______________________________________________
> logback-dev mailing list
> logback-dev at qos.ch
> http://mailman.qos.ch/mailman/listinfo/logback-dev