[logback-dev] [JIRA] Commented: (LBCORE-230) System Properties should override properties in logback.xml (not the other way around)

[Ceki Gulcu (JIRA)]

    [ http://jira.qos.ch/browse/LBCORE-230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12237#action_12237 ] 

Ceki Gulcu commented on LBCORE-230:
-----------------------------------

Thanks for the link describing PropertyPlaceholderConfigurer. You made a good case for looking up system properties first. Admittedly, I can't as easily make a case for looking up local first. Having said that and on account of simplicity, I would prefer to offer only one order for looking up properties. As I understand it, providing a  SYSTEM_PROPERTIES_MODE_OVERRIDE is not a good idea, again on account of simplicity.

> System Properties should override properties in logback.xml (not the other way around)
> --------------------------------------------------------------------------------------
>
>                 Key: LBCORE-230
>                 URL: http://jira.qos.ch/browse/LBCORE-230
>             Project: logback-core
>          Issue Type: Improvement
>    Affects Versions: 0.9.29
>            Reporter: Eric Sirianni
>            Assignee: Logback dev list
>            Priority: Minor
>
> From the logback configuration guide (http://logback.qos.ch/manual/configuration.html)
> "The property is not declared in the configuration file, thus logback will look for it in the System properties. Java system properties can be set on the command line. "
> I believe the precedence should be reversed.  Typically, system properties are used to *override* default values of properties that are specified in XML files or property files (typically checked into source control).  Please consider this enhancement.  For backwards compatibility you may want to add an option to toggle the precedence ordering.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira