[logback-dev] [JIRA] Commented: (LBACCESS-17) LogbackValve overrides final start() method from LifecycleBase in Tomcat 7

[Paul Gifford (JIRA)]

    [ http://jira.qos.ch/browse/LBACCESS-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12134#action_12134 ] 

Paul Gifford commented on LBACCESS-17:
--------------------------------------

In addition to overriding startInternal(), stopInternal() should be overridden instead of stop().  Also, at the beginning of each method a call to the overridden method must be included to set the LifecycleState, otherwise an exception will be thrown (e.g. super.startInternal();)

> LogbackValve overrides final start() method from LifecycleBase in Tomcat 7
> --------------------------------------------------------------------------
>
>                 Key: LBACCESS-17
>                 URL: http://jira.qos.ch/browse/LBACCESS-17
>             Project: logback-access
>          Issue Type: Bug
>    Affects Versions: 0.9.26
>            Reporter: Grzegorz Grzybek
>            Assignee: Logback dev list
>            Priority: Critical
>
> {code}
> java.lang.VerifyError: class ch.qos.logback.access.tomcat.LogbackValve overrides final method start.()V
> {code}
> Tomcat 7 has changed the LifecycleBase implementation - it should not override start() but rather startInternal()

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira