[logback-dev] How to contribute to logback?

[ceki]

Submitting pull requests is the way to go.

You used attributes for the passing arguments to SiftingAppender. It
is far easier to use element in which case you don't have to code
anything in SiftAction. Joran (the XML configurator) or Gaffer (the
GroovyConfigurator) will inject the arguments into the SiftingAppender
instance automatically.

Regarding release of resources, SMTPAppender which also uses
AppenderTracker will release release resources whenever an event has
the marker "FINALIZE_SESSION". This is more convenient than waiting
for a timeout as resources are released immediately. Would such an
approach work for you? In other words, can you identify a point in
your code where after which resources should be released?

-- 
Ceki
http://twitter.com/#!/ceki

On 24.10.2012 17:31, Becker, Thomas wrote:
> I've cloned logback on github and implemented an RFE that I filed.  I
> went ahead and submitted a pull request,
> https://github.com/qos-ch/logback/pull/63, though I noticed that there
> are a lot of outstanding pull requests that don't seem to be getting
> addressed.  Is there something that developers looking to contribute
> back need to do, or is it the dev's intention not to accept
> contributions from the community?  With regard to this change
> specifically, we could obviously just use my forked copy, but we would
> prefer to utilize an official released version, and I do feel that other
> people could benefit from the changes.
>
> Regards,
> Tommy Becker
>
>