[logback-dev] [qos-ch/logback] 67b0bf: removed some assertions that were not critical

Carl Harris ceharris at vt.edu
Thu Apr 4 16:00:00 CEST 2013


  Branch: refs/heads/master
  Home:   https://github.com/qos-ch/logback
  Commit: 67b0bfe95d7fdde56d925b779eae9151650d7a55
      https://github.com/qos-ch/logback/commit/67b0bfe95d7fdde56d925b779eae9151650d7a55
  Author: Carl Harris <ceharris at vt.edu>
  Date:   2013-04-04 (Thu, 04 Apr 2013)

  Changed paths:
    M logback-classic/src/test/java/ch/qos/logback/classic/net/SocketRemoteTest.java

  Log Message:
  -----------
  removed some assertions that were not critical

The test was system timing sensitive due to testing some assertions on
fields without proper synchronization.  The assertions themselves were
not especially critical, and adding the synchronization would have added
significant complexity, so the assertions were removed.


  Commit: 216b1c50c97b67e83faff4dac2d3e2d5f95a5758
      https://github.com/qos-ch/logback/commit/216b1c50c97b67e83faff4dac2d3e2d5f95a5758
  Author: Carl Harris <ceharris at vt.edu>
  Date:   2013-04-04 (Thu, 04 Apr 2013)

  Changed paths:
    M logback-classic/src/test/java/ch/qos/logback/classic/net/SocketRemoteTest.java

  Log Message:
  -----------
  Merge pull request #105 from ceharris/socketRemoteTestBrokenOnJenkins

removed some assertions that were not critical


Compare: https://github.com/qos-ch/logback/compare/94ff6ef07ad4...216b1c50c97b


More information about the logback-dev mailing list