[logback-dev] [qos-ch/logback] 5cd256: reduce timing sensitivity in SocketAppenderTest

Carl Harris ceharris at vt.edu
Tue Apr 16 20:44:14 CEST 2013


  Branch: refs/heads/master
  Home:   https://github.com/qos-ch/logback
  Commit: 5cd256d6016970fc54070ef17006384285aa606d
      https://github.com/qos-ch/logback/commit/5cd256d6016970fc54070ef17006384285aa606d
  Author: Carl Harris <ceharris at vt.edu>
  Date:   2013-04-16 (Tue, 16 Apr 2013)

  Changed paths:
    M logback-classic/src/test/java/ch/qos/logback/classic/net/SocketAppenderTest.java

  Log Message:
  -----------
  reduce timing sensitivity in SocketAppenderTest

In the receiveMessage and receiveWithContext tests, only ten
milliseconds were allowed for the appender to dispatch the message over
the socket.  Practical experience suggests that on the build system, the
actual latency is on the order of hundreds of milliseconds.  I changed
the allowed wait time to 1000 milliseconds.  This should have little
impact on test duration, as the test will finish as soon as the latch
we're awaiting is updated.

The number of iterations for the loop in lateServerLaunch was derived
from the delay allowed for the appender latch.  The new value for the
delay resulted in an iteration count of one.  I changed this test to
simply use a fixed iteration count.


  Commit: 3727d7ff0fd33a9584a9ba0ef0369506fa8f562e
      https://github.com/qos-ch/logback/commit/3727d7ff0fd33a9584a9ba0ef0369506fa8f562e
  Author: Carl Harris <ceharris at vt.edu>
  Date:   2013-04-16 (Tue, 16 Apr 2013)

  Changed paths:
    M logback-classic/src/test/java/ch/qos/logback/classic/net/SocketAppenderTest.java

  Log Message:
  -----------
  removed an unused import to silence a build warning in eclipse


Compare: https://github.com/qos-ch/logback/compare/859256759ad2...3727d7ff0fd3


More information about the logback-dev mailing list